v1.0.0 release broken about nats-account-server HOT 3 CLOSED

@burner-account Sorry for the unpleasant experience using this repository. I have merged PR #80 and made also some updates to vendor directory, etc.. For sure, this repo does not have the same attention/usage than some other repos such as the NATS Server, etc.. so it is true that probably the code was not up-to-date with latest staticcheck. Maybe we should run a cron job on Travis once a month or something like that.

Keep in mind that staticcheck evolves often and it is possible that some checks are found now that would not have been reported earlier.

Your report is a bit misleading in that the release v1.0.0 (both executable and existing docker image: docker run natsio/nats-account-server:1.0.0) is not broken. What I suspect has happened, is that you forked/cloned the repo at v1.0.0 tag and tried to build and/or use staticcheck with versions different than what v1.0.0 was built on back in March of this year?

Regardless, I will sync with some of my colleagues and see if we do another release soon and how to put in place checks so that hopefully does not happen again. Thank you for your understanding.

from nats-account-server.

@kazlovic Thank you very much for your immediate action.
Indeed, i did not use the executable or the pre-built docker image. I followed the instructions from the READ.ME "Building the server" with tag v1.0.0 in order to build a custom docker image that better fits the config/secret injection mechanics of my CI/CD system.
Please excuse me letting you have a taste of my disappointment.

from nats-account-server.

@burner-account No worries. I have a PR to add a note in the "building the server" section. I hope this helps: #84

from nats-account-server.