natethegreatt / bitecs-threejs-poc Goto Github PK

What is the performance of combining bitECS with three.js? Will it deteriorate?

First of all, I like that there's a desire for integration on the THREE front.

This POC seems to highlight some issues that I believe can be addressed, but I'd like to ask if there's a canonacal way to handle them.

1. The hierarchy used in the demo is not synced with the ECS, so saving (serializing) the ECS data and restoring (deserializing) it later would not properly join the THREE objects.
2. The camera is not an entity, so it can't be moved as one. If it was, we'd want to make it a child of an object with just a transform, so we could move the camera, but still allow a VR system to move the camera itself.
3. There's no lighting, but if there was, it would need to be a transformable object as menchened in the other 2.

I think that these all point to the fact that there needs to be a hierachy (parent and child) relationship.

As a side note, the movement should probably use a modulus of angle values based on the total time instead of adding a delta time based value. The current implementation runs into numerical issues after a few minutes.

I'd be happy to submit a PR if I knew how to make a hierarchy in BitECS. Can someone point me to an example?