nasa-pds / pds-view Goto Github PK

Checked for duplicates

No - I haven't checked

🐛 Describe the bug

🕵️ Expected behavior

📜 To Reproduce

...

🖥 Environment Info

• Version of this software [e.g. vX.Y.Z]
• Operating System: [e.g. MacOSX with Docker Desktop vX.Y]
  ...

📚 Version of Software Used

No response

🩺 Test Data / Additional context

No response

🦄 Related requirements

🦄 #xyz

⚙️ Engineering Details

No response

OS: Mac OSX 10.14.5

Trying to resize fields, UI does not "let go" of cursor to complete resizing.

Describe the bug
It seems the created PDS4 label still contains some unresolved velocity(?) variables in the output temporary label.

To Reproduce
Steps to reproduce the behavior:

1. start PDSView
2. Open SBDR_03_D040_V01.TAB
3. Summary tab lists 3 cols X $object.ROWS
4. This is actually 235 col x 16300 rows (as reported in the docs).

Expected behavior
parse label and be able to open binary table data.

** Version of Software Used**
PDSView v0.4.0

Test Data / Additional context
Here is an example (requires the FMT):
https://pdsimage.wr.usgs.gov/archive/co-v_e_j_s-radar-3-sbdr-v1.0/CORADR_0040/DATA/SBDR/

Desktop (please complete the following information):

• OS: Windows 10

Note NASAView sort of works to open but easily runs into issues.

🐛 Describe the bug

/root/Downloads/PDSView-debian-10/PDSView
Traceback (most recent call last):
  File "pyinstaller-hook.py", line 33, in <module>
ImportError: No module named sip

📜 To Reproduce

Try to install application on Debian Linux environment.

🕵️ Expected behavior

📚 Version of Software Used

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

Python 3.9.10 (main, Jan 16 2022, 02:41:55) [GCC 11.2.0] on linux

🦄 Related requirements

⚙️ Engineering Details

9P_Tempel_1-pre1.506-20050702.52-irs.csv.txt

9P_Tempel_1-pre1.506-20050702.52-irs.xml.txt

Create a new branch in the search UI repository that uses material UI.

https://pds-jira.jpl.nasa.gov/browse/CCB-264

CCB-264.pdf

minimal_test_product_line_endings.zip

In my home directory on pds-gamma is pdsview30.zip, what has an Array_2D. PDS View shows it only as a Table, and then only one column.

Describe the bug
v0.4.0 PDSView-windows-dir.zip .exe gets stopped by antivirus. Two files get quarantined.

To Reproduce
Execute PDSView-windows-dir.zip's PDSView.exe

Version of Software Used
PDSView v0.4.0

Screenshots

Desktop (please complete the following information):
Windows 10 Enterprise 64-bit (10.0 Build 17763) with Symantec

Additional notes
The single executable version still works.

See here: https://github.com/Homebrew/homebrew-cask/blob/master/doc/development/adding_a_cask.md

Setting this up would make adoption of the tool even easier (for Mac users, at least).

Describe the bug
If the user has first hidden the axis ticks, using the "Show rectangular table selection on image" function shows the ticks again (whilst the option in Image Options/Ticks remains de-selected).

Version of PDS View
Version: 0.4.0

To Reproduce
Steps to reproduce the behaviour:

1. Load a product containing an image
2. Go to Image Options/Ticks and click to remove ticks
3. Switch to the Table tab
4. Select a portion of the table
5. Go to Table Options / Show rectangular table selection on image

Expected behavior
The axis display status (shown or hidden) should be maintained

Desktop (please complete the following information):

• OS: ubuntu 18.04

An Inspect Tool Operational guide needs to be added. Initial work was done, but in Word format. It can be obtained by going to the OODT JIRA site:

https://oodt.jpl.nasa.gov/jira/browse/PDS-662

According to @nutjob4life, a lot of open source Python projects are documented at https://readthedocs.org/ (and you can sign in with your GitHub ID and automatically import your projects) and it supports the Sphinx format. Sphinx also lets you use reStructuredText (more common in the Python community) or Markdown (but with limited features).

See also this recommendation for Sphinx for Python: https://python-docs.readthedocs.io/en/latest/writing/documentation.html

This is no longer the Inspect Tool, so the logo should be removed, and instead, prompt the user to open a file as soon as they open the application.

Attempting to open the following PDS3 product from the PSA (Rosetta/MIDAS):

http://psa.esa.int/pdap/download?RESOURCE_CLASS=PRODUCT&ID=RO-C-MIDAS-5-PRL-TO-EXT3-V1.0:DATA:IMG_1612423_1615300_069_ZS::1.0

results in no message/warning/error from the GUI but the following reports in the terminal:

Traceback (most recent call last):
  File "pds_inspect_tool/View.py", line 1155, in file_open
  File "pds_inspect_tool/View.py", line 1135, in pds_file_check
  File "pds_inspect_tool/Translate.py", line 204, in convert_to_pds4
UnboundLocalError: local variable 'offset' referenced before assignment

Describe the bug
The latest release (0.4.0) is built against a specific version of libc6, which is not installed on my system, resulting in the error:

$ ./PDSView 
[12633] Error loading Python lib '/tmp/_MEIm2ZnrJ/libpython2.7.so.1.0': dlopen: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.28' not found (required by /tmp/_MEIm2ZnrJ/libpython2.7.so.1.0)

** Version of PDS View **
Version: 0.4.0

To Reproduce

1. Unzip the linux zip file
2. make executable
3. execute

Desktop (please complete the following information):

• OS: linux
• Version : ubuntu 18.04

Validate now allows non-ascii characters, so I assume that's the right thing to do. PDS View should match validate as well but misses the non-ASCII characters in the attached.

apd.zip

Attached are x.xml and x.jpg. The latter should be named x.dat, but github disapproved. The data file was originally 300+k records, but PDSView hangs on the reduced one as well.

Also attached are the output of Lev's PDS4 Viewer

And in the off chance it matters, the highlighting of PDSView's top row of icons changes after I hit "View", when it then hangs.

Debian and ubuntu versions do not work on CentOS. Need a version compiled on CentOS.

Please make the installation documentation clear that this will only work on Mac OS greater than 10.12.6.

Describe the bug
Attempting to open a PDS3 binary table fails when clicking View in the GUI, with the following errors:

(base) mbentley@bpcl03:~/Desktop/psa_data$ ~/Dropbox/software/pds/PDSView 
DEBUG:./logfile:2019-09-18 15:52:47,604:Initializing logger
DEBUG:./logfile:2019-09-18 15:52:47,604:Parsing header
DEBUG:./logfile:2019-09-18 15:52:47,605:Parsed 43 top-level labels
Processing label: /home/mbentley/Desktop/psa_data/MIRO_4_MM1S_2016272.xml
Found a Table_Binary structure: DESCRIPTION_0
Warning: <fields> value does not match number of <Field_Binary> in Record_Binary.
Error: min() arg is an empty sequence
Traceback (most recent call last):
  File "pds_view/View.py", line 1509, in handle_view_clicked
  File "pds_view/View.py", line 1755, in draw_table
  File "pds_view/Model.py", line 301, in get_table
  File "eggs/pds4_tools-1.0-py2.7.egg/pds4_tools/extern/cached_property.py", line 86, in __get__
  File "eggs/pds4_tools-1.0-py2.7.egg/pds4_tools/reader/table_objects.py", line 368, in data
  File "eggs/pds4_tools-1.0-py2.7.egg/pds4_tools/reader/read_tables.py", line 951, in read_table_data
  File "eggs/pds4_tools-1.0-py2.7.egg/pds4_tools/reader/read_tables.py", line 709, in new_table
ValueError: min() arg is an empty sequence

I have attached the PDS3 product, the corresponding format file (which is in the same directory as the product) and the failing auto-generated PDS4 label (in which the fields are not defined). Note that if I use transform 1.7 on this label, I get a correct PDS4 label that works correctly with the data file.

Version of PDS View
Version: 0.4.0 ubuntu

To Reproduce
Load the attached product and click View on the table.

Desktop (please complete the following information):

• OS: ubuntu 18.04

MIRO_4_MM16_2016272.zip

We must identify the current starting point by using the USWDS or NASAWDS and decide which makes a better starting point.

USWDS: https://designsystem.digital.gov
NASAWDS: https://nasa.github.io/nasawds-site/

Checked for duplicates

Yes - I've already checked

🐛 Describe the bug

Can't open Tianwen-1 NaTeCam PDS4 data
Here is the example
https://github.com/BG9OXA/pds4-example/raw/main/HX1-Ro_GRAS_NaTeCamB-F-002_SCI_N_20220412171345_20220412171345_00325_A.2CL
https://github.com/BG9OXA/pds4-example/raw/main/HX1-Ro_GRAS_NaTeCamB-F-002_SCI_N_20220412171345_20220412171345_00325_A.2C
I try to rename HX1-Ro_GRAS_NaTeCamB-F-002_SCI_N_20220412171345_20220412171345_00325_A.2CL to HX1-Ro_GRAS_NaTeCamB-F-002_SCI_N_20220412171345_20220412171345_00325_A.xml
but rgb table is empty

Thanks a lot!

🕵️ Expected behavior

I expected open it and save as a normal picture,such as jpg, png or tif

🖥 Environment Info

• Latest Version
• Win10 Desktop

I'm not sure if the imageextractor module is actually used by pds-view, but when using the standalone PyPDS library, my file referenced in issue #8 fails to load since it expects an image object name which is simply IMAGE, rather than having an arbitrary prefix (in this case BCR_IMAGE) (see this line and the next)

I renamed the .img to .jpg to get it into github. The other .jpg is a screen capture of Lev's program after clicking "Table" for row 0.
andc_3519_50_0_a.xml.txt

I get errors when trying to open lunar GPR data from the recent data release from the Yutu 2 rover. I would like to view these radar data.

Data source
http://moon.bao.ac.cn/pubMsg/detail-CE4EN.jsp#
LPR Level 2B Scientific Data

To Reproduce
Steps to reproduce the behavior:

1. Open app.
2. Select .2BL or .2B
3. Click Profile
4. See error

Expected behavior
A clear and concise description of what you expected to happen.
I wanted to view the radar profile.

** Version of Software Used**
PDS4_viewer_mac10_13-1.1

Test Data / Additional context
Add test data or any other context about the problem here.
ChinaLunarRadar.zip

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

• Browser =chrome
  Model Name: MacBook Pro
  Model Identifier: MacBookPro12,1
  Processor Name: Dual-Core Intel Core i5
  Processor Speed: 2.9 GHz
  Number of Processors: 1
  Total Number of Cores: 2
  L2 Cache (per Core): 256 KB
  L3 Cache: 3 MB
  Hyper-Threading Technology: Enabled
  Memory: 16 GB
  Boot ROM Version: 191.0.0.0.0
  SMC Version (system): 2.28f7

Applicable requirements
I downloaded the App from:
http://sbndev.astro.umd.edu/wiki/PDS4_Viewer

Error when displaying the Table or Profile.
Now processing a Table_Binary structure: TABLE_0
Warning: field_format 'None' does not conform to PDS4 standards for field 'FRAME_IDENTIFICATION' (full location: 'FRAME_IDENTIFICATION')
Warning: field_format 'None' does not conform to PDS4 standards for field 'TIME' (full location: 'TIME')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'VELOCITY' (full location: 'VELOCITY')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'XPOSITION' (full location: 'XPOSITION')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'YPOSITION' (full location: 'YPOSITION')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'ZPOSITION' (full location: 'ZPOSITION')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'ATT_PITCHING' (full location: 'ATT_PITCHING')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'ATT_ROLLING' (full location: 'ATT_ROLLING')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'ATT_YAWING' (full location: 'ATT_YAWING')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'REFERENCE_POINT_XPOSITION' (full location: 'REFERENCE_POINT_XPOSITION')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'REFERENCE_POINT_YPOSITION' (full location: 'REFERENCE_POINT_YPOSITION')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'REFERENCE_POINT_ZPOSITION' (full location: 'REFERENCE_POINT_ZPOSITION')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'REFERENCE_POINT_ATT_PITCHING' (full location: 'REFERENCE_POINT_ATT_PITCHING')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'REFERENCE_POINT_ATT_ROLLING' (full location: 'REFERENCE_POINT_ATT_ROLLING')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'REFERENCE_POINT_ATT_YAWING' (full location: 'REFERENCE_POINT_ATT_YAWING')
Warning: field_format 'None' does not conform to PDS4 standards for field 'DataParameter1' (full location: 'DataParameter1')
Warning: field_format 'None' does not conform to PDS4 standards for field 'RADAR_WORKING_MODE' (full location: 'RADAR_WORKING_MODE')
Warning: field_format 'None' does not conform to PDS4 standards for field 'RADAR_CHANNEL_1_GAIN_MODE' (full location: 'RADAR_CHANNEL_1_GAIN_MODE')
Warning: field_format 'None' does not conform to PDS4 standards for field 'RADAR_CHANNEL_1_GAIN_VALUE' (full location: 'RADAR_CHANNEL_1_GAIN_VALUE')
Warning: field_format 'None' does not conform to PDS4 standards for field 'RADAR_CHANNEL_2_GAIN_MODE' (full location: 'RADAR_CHANNEL_2_GAIN_MODE')
Warning: field_format 'None' does not conform to PDS4 standards for field 'RADAR_CHANNEL_2_GAIN_VALUE_1' (full location: 'RADAR_CHANNEL_2_GAIN_VALUE_1')
Warning: field_format 'None' does not conform to PDS4 standards for field 'RADAR_CHANNEL_2_GAIN_VALUE_2' (full location: 'RADAR_CHANNEL_2_GAIN_VALUE_2')
Warning: field_format 'None' does not conform to PDS4 standards for field 'DataParameter2' (full location: 'DataParameter2')
Warning: field_format 'None' does not conform to PDS4 standards for field 'VALID_DATA_LENGTH' (full location: 'VALID_DATA_LENGTH')
Warning: field_format 'None' does not conform to PDS4 standards for field 'CHANNEL_1_RECORD_COUNT' (full location: 'CHANNEL_1_RECORD_COUNT')
Warning: field_format 'None' does not conform to PDS4 standards for field 'CHANNEL_2_RECORD_COUNT' (full location: 'CHANNEL_2_RECORD_COUNT')
Warning: field_format 'None' does not conform to PDS4 standards for field 'CHANNEL_AND_ANTENNA_MARK' (full location: 'CHANNEL_AND_ANTENNA_MARK')
Warning: field_format 'F.6' does not conform to PDS4 standards for field 'ECHO_DATA' (full location: 'ECHO_DATA -> ECHO_DATA')
Warning: field_format 'None' does not conform to PDS4 standards for field 'QUALITY_STATE' (full location: 'QUALITY_STATE')
Error: An error occurred during data read-in.
Traceback (most recent call last):
File "pds4_tools/viewer/summary_view.pyc", line 171, in _reify_structure
File "pds4_tools/extern/cached_property.pyc", line 86, in get
File "pds4_tools/reader/table_objects.pyc", line 362, in data
File "pds4_tools/reader/read_tables.pyc", line 951, in read_table_data
File "pds4_tools/reader/read_tables.pyc", line 766, in new_table
File "pds4_tools/reader/table_objects.pyc", line 400, in set_field
File "pds4_tools/reader/data.pyc", line 319, in set_field
ValueError: could not broadcast input array from shape (428) into shape (107)

Describe the bug
When attempting to open the example product provided with nasaview-3.18.0_linux64 (FHA01118.LBL) PDS View crashes with the output:

DEBUG:./logfile:2019-09-12 15:50:51,664:Initializing logger
DEBUG:./logfile:2019-09-12 15:50:51,665:Parsing header
DEBUG:./logfile:2019-09-12 15:50:51,666:Parsed 33 top-level labels
Traceback (most recent call last):
  File "bin/PDSView", line 21, in <module>
  File "/home/kelly/pds-view/eggs/PyInstaller-3.4-py2.7.egg/PyInstaller/loader/pyimod03_importers.py", line 395, in load_module
  File "pds_view/View.py", line 3072, in <module>
  File "pds_view/View.py", line 3067, in main
  File "pds_view/View.py", line 3048, in __init__
  File "pds_view/View.py", line 699, in __init__
  File "pds_view/View.py", line 1158, in file_open
  File "pds_view/View.py", line 1138, in pds_file_check
  File "pds_view/Translate.py", line 215, in convert_to_pds4
  File "eggs/airspeed-0.5.11-py2.7.egg/airspeed/__init__.py", line 186, in load_template
  File "genericpath.py", line 62, in getmtime
OSError: [Errno 2] No such file or directory: '/tmp/_MEIDvAaXA/./templates/InspectTemplate.vm'
[30634] Failed to execute script PDSView

** Version of PDS View **
Version: v0.4.0 ubuntu package

To Reproduce
Steps to reproduce the behavior:

1. Start PDS View
2. Select product FHA01118.LBL (FHA01118.zip)

Desktop (please complete the following information):

• OS: ubuntu
• Version: 18.04

The vertical orientation for the first Array_2D_Image is wrong. The .xml has
disp:vertical_display_directionTop to Bottom</disp:vertical_display_direction>
which I assume is correct, as Lev's viewer orients this correctly.

However, there might legitimately be insufficient information. Validate passes the label, but Lev's viewer may just be lucky because it first complains that "No valid/supported Display Settings found."

The file is too big to attach here. Grab it from my home directory on pds-gamma, view29.zip

Describe the bug
This is a simple indexing error:
Line 1128 of View.py:
extension = fname.split('.')[1].upper()
Will not return the extension as desired if a period proceeds it in the path.

** Version of PDS View **
Version:

To Reproduce
Create a path that has a period it it before the file name:
e.g. mybrance/python2.7.12/pds4_files/test_array.xml
This will not return the '7' as the extension

Expected behavior
Test for a know extension. If 'XML' continue, if another know extension, assume PDS3 file and translate the file to PDS4 xml.

Fix
Simple change the index to use the last period to split the string:
extension = fname.split('.')[-1].upper()