naokim03 / p-m2m-rs Goto Github PK

View Code? Open in Web Editor NEW

0.0 1.0 0.0 37 KB

License: MIT License

Rust 100.00%

p-m2m-rs's Introduction

p-m2m-rs

p-m2m-rs's People

Contributors

Watchers

p-m2m-rs's Issues

Why doesn't `lefts` return an iterator?

The lefts return Option<Vec<&L>>, since this crate is focused on easy implementation, not memory or speed.

`sort` and `dedup` vs using `HashSet`

It can also be paraphrased as Ord vs Eq + Hash.
For small collections, the former (Ord) was clearly faster.
The difference narrowed as the size of the collection increased, but never reversed.
I need to try with more complex patterns.

Alternatively, I would consider splitting the implementation by features.

impl<L, R> FromIterator<(L, R)> for M2M<L, R>
where
    L: Eq + Hash,
    R: Eq + Hash,
{
    #[inline]
    fn from_iter<T: IntoIterator<Item = (L, R)>>(iter: T) -> Self {
        let v: Vec<(L, R)> = iter
            .into_iter()
            .collect::<HashSet<(L, R)>>()
            .into_iter()
            .collect();

        M2M(v)
    }
}

`get_rights` vs `get_by_left`

pub fn get_rights(&self, left: &L) -> Option<Vec<&R>> where L: PartialEq,

pub fn get_by_left(&self, left: &L) -> Option<Vec<&R>> where L: PartialEq,

Use `binary_search` inside `contains`

impl<L, R> M2M<L, R> {
    fn contains(&self, pair: &(L, R)) -> bool
    where
        (L, R): Ord,
    {
        self.0.binary_search(pair).is_ok()
    }
}