nanreh / calendar-hack Goto Github PK

I did a quick test using Accessibility Insights and manually checking a few things and here's a list of issues I found:

• H3 is used to style text "ending on" even though it is a label for an input element, not a true heading. Suggestion is to replace <h3> with a with an id and add it as the "for" attribute on the input element
• Home/Github/About links don't have labels (need a "title" attribute or "aria-label" attribute)
• The "select" element for workouts should have an aria label
• Mi/Km radio buttons should be in a radio group with an aria label
• Keyboard focus isn't visible on the workout select dropdown, unit radio buttons, or the "Download" button
• Date text on purple doesn't meet wcag color contrast requirements. The text should be a bit darker or the purple should be a bit lighter. This tool allows checking for AA levels.
  
• Unable to reorder items with the keyboard. Suggestion is to make each calendar day focusable (or an element inside focusable) and allow keyboard shortcuts such as arrow keys or some other combination of keys to reorder them.

I'd be happy to submit a PR to fix some of these issues

Great Project!

In Israel the first day of the week is Sunday (usually long runs on Saturday).
Will be great if we can pick the first day of the week according to user preferences.

Error in calendar-hack/public/plans/csv/pfitz_18_55.csv, line 62

The distance is not entered as a variable, but as plain text, and the mi-km conversion in the plain text is incorrect

Line reads: "Long run 18 mi (34 km)","",18
Line should read: "Long run {18}","",18

Great project. I am a runner based in the UK and we use DD/MM/YY date format rather than MM/DD/YY. Would it be possible to add an option to change the date format in the web app or automatically format this according to user locale? Thanks for your work.
Ian

I've created the Pfitz multiple marathons 4 weeks plan from the third edition of the Pfitzinger/Douglas book
pfitz_4_multiple.csv

Some plans have text titles + descriptions for the weeks in a plan. One example are the plans from Faster Road Racing which include a "Postrace Recovery Week". Would have at least optional week title and maybe week description provided by plan authors and then shown in the plan renderings.