Git Product home page Git Product logo

ku-polls's People

Contributors

nabhan-au avatar

Watchers

 avatar

ku-polls's Issues

Comments

Iteration 2

  • The goals are not written in complete sentences.
  • All tasks are completed.
  • Included iteration 2 branch, and merged to main/master.
  • The methods in the questions class in models.py are sufficiently complete. The lines 51-53 in can_vote() method can be refactored into just a single return statement.
  • Externalized configurations are okay. However the DEBUG config() does not contain cast=bool. Also, it is recommended to have default config values.
  • Navigation back to polls index page from detail page and result page is complete.

Continuous Integration

  • CI build and Codecov badge are complete.

Iteration 3

  • The goals are not written in complete sentences.
  • Have only a few tasks, though all of them are complete.
  • No users fixture file. Polls fixture file data cannot be loaded. The votes field must be removed to make loading possible.
  • No sample users provided in the README.md
  • No logout button/hyperlink
  • "1 vote per poll per user" is implemented correctly.
  • "Only authenticated user can vote" works correctly.

Additional Comments

I will give you a chance to fix the polls.json fixture. Contact me in discord once you have fixed it, so that I can regrade it.

Add end_date

add end date of question and add to admin page

Improve navigation

  • On polls index page, add “vote” and “results” links for each question.
  • Only show “vote” link for a poll where voting is allowed.
  • On the polls detail page, add a “Back to List of Polls” link so person can go back without voting. You can use your choice of text instead of “Back to List of Polls”.
  • On the voting results page, also add a “Back to List of Polls” link.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.