Git Product home page Git Product logo

Comments (12)

N8python avatar N8python commented on July 21, 2024

Try turning gamma correction off.

from n8ao.

LR17 avatar LR17 commented on July 21, 2024

Unfortunately it does not help. Also tried creating my own beauty render target but without success

from n8ao.

N8python avatar N8python commented on July 21, 2024

Try on the pass itself - configuration.gammaCorrection

from n8ao.

LR17 avatar LR17 commented on July 21, 2024

That's the property I set, but does not help

from n8ao.

N8python avatar N8python commented on July 21, 2024

Very strange. What is the color space of your render target - could you perhaps share your code?

from n8ao.

LR17 avatar LR17 commented on July 21, 2024
this.effectComposer = new THREEX.EffectComposer(this.renderer);
this.effectComposerSSAOPass = new N8AOPass(this.scene, this.perspectiveCamera, width, height);
this.effectComposerSSAOPass.configuration.gammaCorrection = false;
this.effectComposerOutputPass = new THREEX.OutputPass();

this.effectComposer.addPass(this.effectComposerSSAOPass);
this.effectComposer.addPass(this.effectComposerOutputPass);

from n8ao.

N8python avatar N8python commented on July 21, 2024

Is the threeX output pass doing gamma correction where it shouldn't? Which version of n8ao does ThreeX use?

from n8ao.

LR17 avatar LR17 commented on July 21, 2024

Hello,
THREEX is an alias to import three/examples/jsm, using three r156 and n8ao 1.6.8
OutputPass is doing tone mapping and colorspace conversion

from n8ao.

N8python avatar N8python commented on July 21, 2024

Strange. I am geniunely not sure what could be causing this. Try it without OutputPass maybe?

from n8ao.

CodyJasonBennett avatar CodyJasonBennett commented on July 21, 2024

This is likely from r155 where in mrdoob/three.js#26371, when rendering to a render target, tone-mapping is internally disabled. You're expected to now include a tonemapping or output pass when using post-processing.

from n8ao.

N8python avatar N8python commented on July 21, 2024

N8AO automatically gamma corrects (this can be disabled)... so it shouldn't be an issue with the library.

from n8ao.

N8python avatar N8python commented on July 21, 2024

Closing due to inactivity. Reopen if the issue is still relevant!

from n8ao.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.