mystijk / ormma Goto Github PK

In line 90 of OrmmaSensorController.java:
mOrmmaView.injectJavaScript("Ormma.gotShake()");

gotShake does not exists since 02 March 2011.
It should be:
mOrmmaView.injectJavaScript("window.ormmaview.fireShakeEvent()");

http://code.google.com/p/ormma/wiki/ORMMA_JavaScript

There is stated multiple times that returned values are in json:
> return values: JSON - {x, y, z}

Reference implementation returns javascript object instead. Seems that 
returning javascript object is right and problem is in documentation, not 
reference implementation.

JSON is encoded string with specific format, so if it was returning JSON, 
return value would be string.

> return values: {interval, intensity}

Need to specify, in what units will be interval and intensity

> return values: JSON - {x, y, z}

Need to specify in what units x, y, z

AdRequest

http://api.crispwireless.com/adRequest.v1/single/ad.html?sitekey=ORMMA&zonekey=L
evel_3&partnerkey=945344a4ac19d2b72d29bf03edecf5b5&random=1234

results in browser output:

<!--
Error: Ad Connector Error Publisher 266 does not have any zones setup 
-->

What steps will reproduce the problem?

1 - Load an ad with command
  ormmaView.loadFile(file, fullString); 
//(NB file is empty and fullstring is my ormma code)


2 - ORMMA.js ann ormma_bridge.js  are  not loaded in the webview.

when I press ORMMA Ad i receive :

Uncaught ReferenceError: ormma is not defined at file:///data/data/<Name of 
app>/files/ad/d41d8cd98f00b204e9800998ecf8427e//_ormma_current:52


3  - Details
The files are  copied into the ASSET (ormma.js and ormma_bridge.js) are visible 
into /data/data/<Name of app>/files/ad/<reference>/_ormma_current .  On Android 
the following line are added in the AD

<script src="file://data/data/<here name of app>/files/js/ormma_bridge.js" 
type="text/javascript"></script>

<script src="file://data/data/<Name of app>/files/js/ormma.js" 
type="text/javascript"></script>

I have add this line 
Into the OrmmaAssetController -> writeToDiskWrap

 out.write(("<script type=\"text/javascript\">  if (typeof window.ormma != \"undefined\") {alert(\"ORMMA is loaded\");} else {alert(\"ORMMA is not loaded!\");}</script>").getBytes());

Then  I always receive "ORMMA is not loaded!"

So I injected directly the 2 files (.js)  by this ways

out.write(("<script type=\"text/javascript\">").getBytes());
 InputStream insss = new FileInputStream(bridgePath);
byte[] buf = new byte[1024];
int len;
while ((len = insss.read(buf)) > 0) 
{
out.write(buf, 0, len);
 }
out.write(("</script>").getBytes());

Then  Now I  receive "ORMMA is loaded!" and I can expand the spot.


What is the expected output? What do you see instead?

Ormma founction should be caught.


What version of the product are you using? On what operating system?

 - We use the trunk version 
 - Test platform Android is 4.0.3 

Please provide any additional information below.

The documentation for addEventListener indicates different supported event 
names than the "Events" section of the documentation. Please clarify if the 
event names are to be "resize", "orientation", "network", etc or 
"resizeChange", "orientationChange", "neworkChange" etc. The total listing of 
event names is generally inconsistent between these two sections of the 
documentation. 

The documentation indicates that an event listener will be called with 
parameters specific to the event being broadcasted. This would be better 
implemented with all listeners receiving an event object with a .type property 
as well as the other event-type-specific properties.

Most implementations of addEventListener process event names in lowercase 
internally. Suggesting camelCased event names to implementors could be 
confusing if events call their listeners with a more standard event parameter 
that has a .type property - the type will come back to the handler in lowercase.

Description:
Using the L1 ad sample in the ORMMA repos, after the user clicks through to the 
WebBrowser and closes the WebBrowser, the previously clicked (expanded) ad is 
not present.  There is only a blank backdrop of the view where the ad had been 
previously.

What steps will reproduce the problem?
1. Load the L1 ORMMA test ad into a test app that implements the ORMMA SDK RI.
2. Expand the ad.
3. Click the hot spot to click through.
4. Once the landing page loads, click "X" to exit the web browser.
5. Upon return to the adview, observe referenced behavior (see attachment).

What is the expected output? What do you see instead?
I believe the expected outcome is that the expanded ad unit should be returned, 
but I haven't traced the code to find out the exact intentions.

Log Trace:
2011-02-24 17:55:45.182 ORMMATest[9839:207] Close Button Pressed.
2011-02-24 17:55:45.182 ORMMATest[9839:207] Use Delegate to Dismiss Browser
2011-02-24 17:55:45.183 ORMMATest[9839:207] Dismissing Browser
2011-02-24 17:55:45.183 ORMMATest[9839:207] View Will Appear
2011-02-24 17:55:45.184 ORMMATest[9839:207] ORMAView Delegate Call: adWillShow
2011-02-24 17:55:45.185 ORMMATest[9839:207] Resume Called, Counter at: 1
2011-02-24 17:55:45.185 ORMMATest[9839:207] ORMAView Delegate Call: adDidShow
2011-02-24 17:55:45.586 ORMMATest[9839:207] View Did Appear

When I checkout from SVN, I should be able to automatically load it into a 
context where the Android libs are provided. This is not currently the case. 

Is there currently a method to asynchronously check if the ormma compliant 
library has hit the ORMMAReady state?  Currently, I believe the only way to do 
so is to define the ORMMAReady() function in global scope and wait for the 
synchronous call to that function.  Wouldn't be a good idea to be able to 
reference if the library has hit the ready state through a boolean such as 
ormma.isORMMAREADY?  Also, if that were the case, that would render the 
ORMMAReady() function optional and give more control to the ad designer to take 
care of initialization themselves.  Also, now that I think of it, why not 
change ORMMAReady to be event driven with the callback function defined by the 
user?

Given a device with a large amount of screen real-estate and displaying 
multiple ads, if one ad becomes "active" and sends the application a "suspend" 
message, the ORMMA SDK should be able to notify all other ads of this fact and 
those ads should suspend as well.

This means, among other things, that if the ad is running a timer that may 
result in a display change (i.e. automatically going into an expanded state for 
example) this should be explicitly disallowed.

Additionally, when the ad sends the "resume" notification, it should in turn 
notify all other ads and allow them to restart.

http://code.google.com/p/ormma/wiki/ORMMA_JavaScript#sendSMS :

> recipient - String, the email address for the message. Several recipients are 
seperated by ; or ,

Possible should be phone number.

What steps will reproduce the problem?
1. Downloading the .xcodeproject from the svn.
2. Running it as an iOS application.
3. Clicking "Load Ad" button and loading 
http://ormma.googlecode.com/svn/trunk/AdSamples/OrmmaOneAd/OrmmaOne.html.

The expected output is as described in the html file itself:
"The expected behavior of this ad is to display the banner automatically, click 
to banner expand, click the X to collapse and click the X again to hide the ad."

What do you see instead?
Immediately after the ad-space is displayed, it is resized to zero-height and 
disappears.

Version / OS:
The SVN I used was downloaded yesterday so it should be up to date.
I tested on iPhone 3GS and iPad.

Additional information:
I've seen similar issues and behaviors when I tried to use the ormma.resize() 
method. The ad-space either collapsed to zero-height or resized to about 70% of 
the screen's height regardless of what width/height arguments I sent through 
the resize() method.

The documentation states that expand expects a single parameter, url.

At least some of the sample files in the project are sending two parameters - 
dimensions, url.

Here's the files I've seen it used:
/trunk/WebTester/safari/ormma.js 
/trunk/AdSamples/OrmmaOneAd/OrmmaOne.js

Description:
The ormma.expand function in ormma.js 
(http://code.google.com/p/ormma/source/browse/trunk/iOS/AdContainer/ORMMA/Resour
ces/Javascript/ormma.js) expects two paramters: dimensions and URL.  In the 
current implementation of OrmmaOne.js (see below), it appears you are sending 
two JSON parameters consisting of top, left, bottom, and right; which appears 
to be incorrect.  Looking at the ormma.js resource file, the valid function on 
line 342 appears to expect a dimensions JSON parameter in the form of height, 
width, x, and y, based on the dimensionValidators parameter passed into the 
valid function on line 414.  I have changed this locally and it appears to 
correct he issue of expanding inside my test app with this ad unit.

File: 
http://code.google.com/p/ormma/source/browse/trunk/AdSamples/OrmmaOneAd/OrmmaOne
.js r299
Function: ormmaExpand()
Lines 113-126

Bug: Line 123, call to ormma.expand(dimensions, URL)

Current (bug):
ormma.expand({'top' : 0, 'left' : 0, 'bottom' : 100, 'right' : 100}, {'top' : 
0, 'left' : 0, 'bottom' : 300, 'right' : 300});

Alternative (works):
ormma.expand({'height' : 300, 'width' : 300, 'x' : 0, 'y' : 0}, null);

-Daniel Spring

H: [email protected]
O: [email protected]
Google Alias: dspring0021

Please delete issue 22. I used the wrong email and won't see responses.

What steps will reproduce the problem?
1. Take testbed app or your own app implementing ORMMA
2. Go into AndroidManifest.xml, change minSDKVersion from 7 to 8 and 
targetSDKVersion to something higher (see below)
3. Run the app

What is the expected output? What do you see instead?
I expect no errors and the ad to display. Instead, ad doesn't load and the 
error below is outputted. 

What version of the product are you using? On what operating system?
Android Nexus Tablet (Android 4.0.3)

Please provide any additional information below.

Unfortunately, we don't have the option of using minSDKVersion and 
targetSDKVersion 7 because we need some Android features from SDK 8. I have 
confirmed that changing it back to 7 and temporarily not using the components 
that rely on 8 "solves the issue" but this isn't an adequate.

The code in OrmmaView.loadURL where the error is occurring is below. I'm going 
to need to use AsyncTask to wrap this code into a thread. 

} else {
   is = u.openStream();
}

Error is below:
09-05 16:45:24.777: E/AndroidRuntime(17341): FATAL EXCEPTION: main
09-05 16:45:24.777: E/AndroidRuntime(17341): 
android.os.NetworkOnMainThreadException
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1117)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.InetAddress.lookupHostByName(InetAddress.java:385)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.InetAddress.getAllByNameImpl(InetAddress.java:236)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.InetAddress.getAllByName(InetAddress.java:214)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection.<init>(HttpConnection.java:70)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection.<init>(HttpConnection.java:50)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection$Address.connect(HttpConnection.java:341)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnectionPool.get(HttpConnectionPool.java:87)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection.connect(HttpConnection.java:128)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.openSocketConnection(HttpEngine.java:315)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.connect(HttpEngine.java:310)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.sendSocketRequest(HttpEngine.java:289)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.sendRequest(HttpEngine.java:239)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:27
3)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java
:168)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.URL.openStream(URL.java:462)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
org.ormma.view.OrmmaView.loadUrl(OrmmaView.java:553)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
org.ormma.view.OrmmaView.loadUrl(OrmmaView.java:403)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.clients.android.sampleapp.AdPrototype.displayAd(AdPrototyp
e.java:60)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.clients.android.sampleapp.MainActivity.onSamplerCompleted(
MainActivity.java:263)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.android.controller.AudioSampler.onSamplerCompleted(AudioSa
mpler.java:152)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.android.controller.record.RecordSample.onSamplerCompleted(
RecordSample.java:119)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.android.controller.record.RecordSample$3.run(RecordSample.
java:98)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.Handler.handleCallback(Handler.java:615)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.Handler.dispatchMessage(Handler.java:92)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.Looper.loop(Looper.java:137)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.app.ActivityThread.main(ActivityThread.java:4745)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.lang.reflect.Method.invokeNative(Native Method)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.lang.reflect.Method.invoke(Method.java:511)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
dalvik.system.NativeStart.main(Native Method)

ORMMA is not a commercial entity, nor is the site a .com

What steps will reproduce the problem?
1.I am getting exception mentioned in subject line on platforms(2.3 & higher) 
while trying to load html 
2.I guess javascript to java bridge is causing the issue on platforms 2.3 and 
higher
3.Looking for workaround

What is the expected output? What do you see instead?
ORMMAReady function should get called but it's never getting called on 
platforms 2.3 & higher

What version of the product are you using? On what operating system?
Android 2.3

Please provide any additional information below.
To be precise below statement is causing problem in OrmmaUtilityController 
class.(refer init menthod)
mOrmmaView.injectJavaScript(injection);

Two new calls not implemented on iOS (and of course not on Android either)

Description:
It appears window.ormmaAvail is mispelled as window.ormmaAvial in the below 
file.  Line #'s provided below.  As far as I could tell, only the expand and 
collapse functions had this issue; although, I am still unable to get the ad 
unit to expand proper w/in my test app after having made the correction 
locally--most likely an implementation issue on my side.

File: 
http://code.google.com/p/ormma/source/browse/trunk/AdSamples/OrmmaOneAd/OrmmaOne
.js r299

Lines: 114 and 136

-Daniel Spring

H: [email protected]
O: [email protected]
Google Alias: dspring0021

What steps will reproduce the problem?
1. Install OrmmaTestBed.apk on any Hi-Res (eg 480x800) Android device
2. Run an ormma compliance link from the Test Bed.
3. The Ad does nothing but pops up alert reporting the screen size by calling 
ormma.getScreenSize() when tapping on the ad.

What is the expected output? What do you see instead?
Expecting 480x800 but getting 213x355

What version of the product are you using? On what operating system?
Ormma Release 517 / Android Test Bed / Android emulator running 480x800, 
Android 2.3.3

Please provide any additional information below.
-

What steps will reproduce the problem?
1. Load the sample 
http://ormma.googlecode.com/svn/trunk/AdSamples/CrispTestSuite/display/300x50-ex
pand.html into the ORMMA iOS test app
2. Click banner to expand 
3. Click the ORMMA logo which does an ormma.open(url)
4. Click the X at bottom to close
5. Then click the creative's X to close
6. Banner disappears and app's layout gets weird (see screenshot)

What is the expected output? What do you see instead?
- You should see the default banner view like you did after step #1 above

What version of the product are you using? On what operating system?
- Rev 517 from trunk in iOS 4.3 simulator with Xcode 4.0.2

Please provide any additional information below.

Javascript API docs has getKeyboard method mentioned:
http://code.google.com/p/ormma/wiki/ORMMA_JavaScript#getKeyboard_*

Reference implementation has getKeyboardState method in javascript:
http://code.google.com/p/ormma/source/browse/trunk/iOS/AdContainer/ORMMA/Resourc
es/Javascript/ormma.js#572
but there is no getKeyboard method defined.

Maybe it is mispelled in docs or in reference implementation?

There are a couple of ways to find the heading in javascript: use 
DeviceOrientationEvent or navigator.geolocation.getCurrentPosition, although 
the latter has only returned null as the heading in my tests. The problem is 
that both of these use asynchronous calls to retrieve the results.

Since getHeading is defined as a synchronous call in the ORMMA spec, that means 
we'd have to handle DeviceOrientationEvent or call 
navigator.geolocation.getCurrentPosition in advance of the call which seems 
wasteful, and in the case of getCurrentPosition would give the user a security 
prompt.

Is getHeading only supposed to return a meaningful value when the heading event 
is also already being handled?

What steps will reproduce the problem?
1. Take testbed app or your own app implementing ORMMA
2. Go into AndroidManifest.xml, change minSDKVersion from 7 to 8 and 
targetSDKVersion to something higher (see below)
3. Run the app

What is the expected output? What do you see instead?
I expect no errors and the ad to display. Instead, ad doesn't load and the 
error below is outputted. 

What version of the product are you using? On what operating system?
Android Nexus Tablet (Android 4.0.3)

Please provide any additional information below.

Unfortunately, we don't have the option of using minSDKVersion and 
targetSDKVersion 7 because we need some Android features from SDK 8. I have 
confirmed that changing it back to 7 and temporarily not using the components 
that rely on 8 "solves the issue" but this isn't an adequate.

The code in OrmmaView.loadURL where the error is occurring is below. I'm going 
to need to use AsyncTask to wrap this code into a thread. 

} else {
   is = u.openStream();
}

Error is below:
09-05 16:45:24.777: E/AndroidRuntime(17341): FATAL EXCEPTION: main
09-05 16:45:24.777: E/AndroidRuntime(17341): 
android.os.NetworkOnMainThreadException
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.StrictMode$AndroidBlockGuardPolicy.onNetwork(StrictMode.java:1117)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.InetAddress.lookupHostByName(InetAddress.java:385)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.InetAddress.getAllByNameImpl(InetAddress.java:236)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.InetAddress.getAllByName(InetAddress.java:214)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection.<init>(HttpConnection.java:70)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection.<init>(HttpConnection.java:50)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection$Address.connect(HttpConnection.java:341)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnectionPool.get(HttpConnectionPool.java:87)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpConnection.connect(HttpConnection.java:128)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.openSocketConnection(HttpEngine.java:315)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.connect(HttpEngine.java:310)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.sendSocketRequest(HttpEngine.java:289)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpEngine.sendRequest(HttpEngine.java:239)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpURLConnectionImpl.getResponse(HttpURLConnectionImpl.java:27
3)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
libcore.net.http.HttpURLConnectionImpl.getInputStream(HttpURLConnectionImpl.java
:168)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.net.URL.openStream(URL.java:462)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
org.ormma.view.OrmmaView.loadUrl(OrmmaView.java:553)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
org.ormma.view.OrmmaView.loadUrl(OrmmaView.java:403)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.clients.android.sampleapp.AdPrototype.displayAd(AdPrototyp
e.java:60)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.clients.android.sampleapp.MainActivity.onSamplerCompleted(
MainActivity.java:263)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.android.controller.AudioSampler.onSamplerCompleted(AudioSa
mpler.java:152)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.android.controller.record.RecordSample.onSamplerCompleted(
RecordSample.java:119)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.dgit.secondscreen.android.controller.record.RecordSample$3.run(RecordSample.
java:98)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.Handler.handleCallback(Handler.java:615)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.Handler.dispatchMessage(Handler.java:92)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.os.Looper.loop(Looper.java:137)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
android.app.ActivityThread.main(ActivityThread.java:4745)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.lang.reflect.Method.invokeNative(Native Method)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
java.lang.reflect.Method.invoke(Method.java:511)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:786)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553)
09-05 16:45:24.777: E/AndroidRuntime(17341):    at 
dalvik.system.NativeStart.main(Native Method)