mycroftai / fallback-duckduckgo Goto Github PK

View Code? Open in Web Editor NEW

9.0 9.0 19.0 99 KB

Mycroft AI official Duck Duck Go Skill - used as a fallback if an Utterance can't be matched to an Intent

Home Page: https://mycroft.ai/skills

License: Apache License 2.0

Python 55.61% Gherkin 13.18% QML 31.21%

mycroft mycroft-skill mycroftai mycroft-fallback duckduckgo duckduckgo-api duckduckgo-search hacktoberfest

fallback-duckduckgo's Introduction

DuckDuckGo

Use DuckDuckGo to answer questions

About

Query DuckDuckGo as a fallback when no other Skill can answer the question.

Uses the DuckDuckGo API to provide information.

Examples

"Who is George Washington?"
"What is plasma?"
"Who's Madonna?"

Credits

Mycroft AI (@MycroftAI)

fallback-duckduckgo's People

Contributors

Stargazers

Watchers

Forkers

jarbasskills nielstron devs-mycroft pyth0n39 dragowave luke5sky prime9 dyna-dot msgpo thomascherickal ballisticzer0 emphasize neongeckocom poff-technology brandonsplawski muhareb superfluouss

fallback-duckduckgo's Issues

Add error handling to the API request

Currently no error handling. Unlikely but does happen. Could be DDG service down, or a local network error, etc.

Duckduckgo before Wolfram Alpha?

I'm having trouble getting this to work...
Even uninstalling "fallback-wolfram-alpha" does not seem to remove the seemingly ever-present skill, and duckduckgo does not seem to get a chance.

"Who is" vs "Tell me about"

Companion issue to: MycroftAI/skill-wiki#58

Is your feature request related to a problem? Please describe.
"Who is" requests don't seem to trigger the Wikipedia Skill - or DDG is just way quicker?
Alternatively - "tell me about" directly triggers the Wikipedia Skill but not DDG.

Describe the solution you'd like
Either of these question bases should trigger the Common Query Framework - and both DDG and Wikipedia should be returning it's confidence quickly enough that it can attempt to answer.

loading of skill fails on Pi3b+ fresh install

error remains after restarting pi or reloading skills

18:10:45.824 | INFO     |  6203 | mycroft.skills.skill_loader:load:185 | ATTEMPTING TO LOAD SKILL: mycroft-fallback-duck-duck-go.mycroftai
 18:10:45.918 | INFO     |  6203 | mycroft.skills.settings:get_local_settings:83 | /home/pi/.config/mycroft/skills/mycroft-fallback-duck-duck-go.mycroftai/settings.json
 18:10:45.927 | ERROR    |  6203 | mycroft.skills.skill_loader:_create_skill_instance:295 | Skill __init__ failed with TypeError('expected str, bytes or os.PathLike object, not NoneType')
Traceback (most recent call last):
  File "/home/pi/mycroft-core/mycroft/skills/skill_loader.py", line 292, in _create_skill_instance
    self.instance = skill_module.create_skill()
  File "/opt/mycroft/skills/mycroft-fallback-duck-duck-go.mycroftai/__init__.py", line 294, in create_skill
    return DuckduckgoSkill()
  File "/opt/mycroft/skills/mycroft-fallback-duck-duck-go.mycroftai/__init__.py", line 54, in __init__
    super(DuckduckgoSkill, self).__init__()
  File "/home/pi/mycroft-core/mycroft/skills/common_query_skill.py", line 71, in __init__
    with open(noise_words_filename) as f:
TypeError: expected str, bytes or os.PathLike object, not NoneType
 18:10:45.935 | ERROR    |  6203 | mycroft.skills.skill_loader:_communicate_load_status:351 | Skill mycroft-fallback-duck-duck-go.mycroftai failed to load

New issue comming on new version of mycroft 18.2.5

09:27:44.897 - mycroft.skills.core:load_skill:144 - ERROR - Failed to load skill: mycroft-fallback-duck-duck-go.mycroftai
Traceback (most recent call last):
File "/home/hellcatvn/mycroft-core/mycroft/skills/core.py", line 115, in load_skill
('.py', 'rb', imp.PY_SOURCE)
File "/usr/lib/python3.6/imp.py", line 235, in load_module
return load_source(name, filename, file)
File "/usr/lib/python3.6/imp.py", line 172, in load_source
module = _load(spec)
File "", line 684, in _load
File "", line 665, in _load_unlocked
File "", line 678, in exec_module
File "", line 219, in _call_with_frames_removed
File "/opt/mycroft/skills/mycroft-fallback-duck-duck-go.mycroftai/init.py", line 16, in
import duckduckgo as ddg
ModuleNotFoundError: No module named 'duckduckgo'

ParseError from specific utterances

Describe the bug
Certain utterances result in ParseError

To Reproduce

"Hey Mycroft, what is four score and seven years ago"
See error:

2021-04-28 01:45:30.463 | ERROR | 804 | mycroft.skills.mycroft_skill.mycroft_skill:on_error:835 | An error occurred while processing a request in Duckduckgo Skill
Traceback (most recent call last):
File “/home/pi/mycroft-core/mycroft/skills/mycroft_skill/event_container.py”, line 66, in wrapper
handler(message)
File “/home/pi/mycroft-core/mycroft/skills/common_query_skill.py”, line 76, in __handle_question_query
result = self.CQS_match_query_phrase(search_phrase)
File “/opt/mycroft/skills/mycroft-fallback-duck-duck-go.mycroftai/init.py”, line 133, in CQS_match_query_phrase
answer = self.respond(query[len(test):])
File “/opt/mycroft/skills/mycroft-fallback-duck-duck-go.mycroftai/init.py”, line 109, in respond
r = ddg.query(query)
File “/home/pi/mycroft-core/.venv/lib/python3.7/site-packages/ddg3.py”, line 29, in query
xml = ElementTree.fromstring(response)
File “/usr/lib/python3.7/xml/etree/ElementTree.py”, line 1315, in XML
parser.feed(text)
File “”, line None

Environment (please complete the following information):

Device type: Mark II
Mycroft-core version: 20.8.1
Mycroft container: 2021-04-08

Thanks to Wallyllama for reporting this.