mybyte / tools Goto Github PK

Still the same code block, where there is a statement about adding lbl to the lableList

for (Label lbl : labels) {
if (label.equals(lbl)) {//it seems should't be this way, but should be label.name.equals(lbl)
hit = true;
break;
}
labelList.add(lbl);
}

This looks to be a redundant line because the next code block does the same thing: adding non-hit label to the labelList

if (!hit) {
labelList.add(label); //seems to be redundant because of above statement labelList.add(lbl);
db.setNodeLabels(subjectNode, labelList.toArray(new Label[labelList.size()]));
addedLabels++;
}

So the line can be crossed out?

Thanks for your code. Also I'm new to Neo4j.

I found in the Neo4jBatchHandeler.java class, there is a code block using Label.equal()

for (Label lbl : labels) {
if (label.equals(lbl)) {//it seems should't be this way, but should be label.name.equals(lbl)
hit = true;
break;
}
labelList.add(lbl);
}

According to Neo4j API, http://api.neo4j.org/2.0.0/org/neo4j/graphdb/Label.html
Label.name() is the unique identifier for Label, so it looks like

if (label.equals(lbl))
should be
if (label.name().equals(lbl))

repo.aduna-software.org: Unknown host repo.aduna-software.org