my0n / podsync-helm-chart Goto Github PK

Currently, the configuration template can only be passed in as a string via the parameter configuration.template. This is great for me (I use ArgoCD so having the whole config in git, and under one Application resource, is awesome), but there's probably a few other ways users would like to use the helm chart:

• pass in an existing ConfigMap or Secret as a template with fields that will be populated by the envsubst initContainer
• pass in an existing ConfigMap or Secret without using the template feature
• use a file on an existing volume somewhere that can be manually/programmatically modified
• use that file, but without templating

The podsync configuration value data_dir isn't actually configurable, so the chart should just pass this along as an environment variable. A good name is PODSYNC_DATA_DIR.

Full disclosure, I'm learning as I go. I just read about the checksum/config annotation - something like that would be better than installing a whole separate chart just to automatically update a single file.

configuration.reloaderEnabled can just be removed without creating a new major version; anyone unlucky enough to be using this chart while I'm fiddling around won't be negatively impacted by mistakenly leaving the config value in there because it'll just get ignored.

Currently, you can only have one ingress host. It's not very important, but many services seem to support multiple ingress hosts so this helm chart should probably also do that. The templating mechanism passes along the PODSYNC_HOST variable, so it will need logic added to handle the case of multiple ingress hosts. I suspect the logic would be:

• If a new config variable ingress.backlink is set, then just use that.
• If there's no ingress hosts, then act as though ingress.enabled is false.
• If there's one ingress host, then use that.
• If there's more than one ingress host, then default to the first one.