Git Product home page Git Product logo

Comments (9)

mxgmn avatar mxgmn commented on April 28, 2024

No objections. Since the standard library doesn't support JSON, if you make this PR I'll leave it open like the command line one for people to merge in their forks.

from wavefunctioncollapse.

VelocityRa avatar VelocityRa commented on April 28, 2024

But it does support JSON. I'm planning to use the first method (System.Runtime.Serialization), which is even more compatible than the other one suggested.

from wavefunctioncollapse.

mxgmn avatar mxgmn commented on April 28, 2024

Oh, didn't know this, will consider JSON in future projects then. JSON PR is welcome, but I'll still leave it open since I don't want to support multiple branches.

from wavefunctioncollapse.

VelocityRa avatar VelocityRa commented on April 28, 2024

Not sure what you mean by support multiple branches. I'm gonna handle the JSON parsing in my PR.
Also, if I'm not mistaken, the only file that needs to change is Main.cs (currently less than 60 LoC).

from wavefunctioncollapse.

mxgmn avatar mxgmn commented on April 28, 2024

If I add/remove examples or parameters, I would have to modify JSON parsing and samples.json also.

from wavefunctioncollapse.

VelocityRa avatar VelocityRa commented on April 28, 2024

Ah, I guess that makes sense.
Well, the goal for this was for people to actually use it, not make it harder by forcing them to either fork + merge the PR or paste the changes manually. This goes for the other unmerged PR as well, I doubt the vast majority of people using WFC know about it, let alone go through the trouble of using it.

Anyway, I'll talk with the other dev about the possibility of adding XML support to the C++ version as I originally intended.

from wavefunctioncollapse.

mxgmn avatar mxgmn commented on April 28, 2024

I'll link this command line PR from the readme then.

from wavefunctioncollapse.

VelocityRa avatar VelocityRa commented on April 28, 2024

Yeah that would be better. Might also want to include Install/Build instructions or at least link to the relevant Issue while you're at it (even though it's pretty easy, people have problems apparently).

from wavefunctioncollapse.

mxgmn avatar mxgmn commented on April 28, 2024

Yes, I'm going to.

from wavefunctioncollapse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.