mwpd / basic-scaffold Goto Github PK

First, let me just say this is a cool project. I always enjoy your perspective on OOP, in particular in relation to WordPress.

In regards to this issue specifically, in basic-scaffold.php we attempt to use the Composer auto-loader and fall back to a bundled auto-loader if Composer is not present.

Having two autoloaders seems like extra complexity.

If we're going to have the Infrastructure\Autoloader anyway, perhaps we could use that (and remove Composer autoloading support).

Alternatively, Composer usage could be required and the Infrastructure\Autoloader could be removed.

The particular scenario I'm most concerned about is if a bug is introduced into one of the auto-loaders it could be very difficult to detect if someone's particular setup is using the other auto-loader.

Thanks as always for sharing your work with the community. Cheers.

When passing an array of objects to SimpleView::render() the magic getter tries to escape an object and breaks. That's why SampleLoopService doesn't work, it should render the strings instead of the post object.

e.g. from https://github.com/php-stubs