mwozniak / bookmark-manager Goto Github PK

do it need to setup fatfree framework individually for the setup?

it's not a good idea to use an .ini file for the configuration and placing it in a directory served through http.

browsing to config/config.ini on your demo server shows your database credentials. depending on the way your server, database and db user are setup i can directly access your other databases or inject malware in your database.

adding RewriteRule ^config/? index.php [L] to the .htaccess file makes the config files unreacheable through http.
not a bullet proof solution, but it would make a default (well working) instance safe.
it would be also good to add a notice in the README, telling the users to move the config file out of the directories served by http (and show them how to modify the index.php to achieve it).

and that being said, thanks for the nice tool!
i'm going to test it a bit during the next few days.

PDO: Expression #2 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'bookmarks.cats.tok' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by

• /home/bookmarks/public_html/lib/db/sql/mapper.php:202 DB\SQL->exec(array('SELECT * FROM catgroup;'),array(array()),0)
• /home/bookmarks/public_html/lib/db/sql/mapper.php:240 DB\SQL\Mapper->select('*',NULL,array('group'=>NULL,'order'=>NULL,'limit'=>0,'offset'=>0),0)
• /home/bookmarks/public_html/lib/db/cursor.php:105 DB\SQL\Mapper->find(NULL,array('group'=>NULL,'order'=>NULL,'limit'=>0,'offset'=>0))
• /home/bookmarks/public_html/app/models/CatGroup.php:10 DB\Cursor->load()
• /home/bookmarks/public_html/app/controllers/Controller.php:22 CatGroup->all()
• /home/bookmarks/public_html/index.php:9 Base->run()

This is when the database is setup clean, any ideas how to fix this ?