Git Product home page Git Product logo

Comments (2)

mwaskom avatar mwaskom commented on May 24, 2024

Should probably just reject unless 0 < binwidth <= binrange. Not sure any other parametrization makes sense.

By the way, binwidth is ignored when discrete=True.

Yeah, the parameter is documented as

If True, default to binwidth=1 ...

Maybe "default to" implies that you can override it and should be "set binwidth=1

from seaborn.

jhncls avatar jhncls commented on May 24, 2024

Should probably just reject unless 0 < binwidth <= binrange. Not sure any other parametrization makes sense.

When the data isn't known in advance, in some situations only 0 or 1 data points will pop up. Without setting binwidth, now an empty plot is returned for 0 data points, and a symmetric bin of 1 wide for only one data point. With binwidth set, the code could behave similarly, using that binwidth. A plot showing something a bit reasonable could be friendlier than an error message.

If True, default to binwidth=1 ...

Well, my comment was a suggestion to also allow other integer binwidths for discrete data, shifting the edges by a half. (But maybe this would complicate things too much. Next, people will be asking for discrete units measured fractions, e.g. 1/10ths.)

from seaborn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.