Warnings on latest in heex templates about heroicons_elixir HOT 7 CLOSED

0.3.1 is published on hex.pm!

from heroicons_elixir.

FWIW, I'd been hoping to do something like this:

defp some_component(assigns) do
  ~H"""
  <.icon_component icon={&Heroicons.Solid.lightning_bolt/1} text="Something" />
  """
end

defp icon_component(assigns) do
  ~H"""
  <%= @icon.(class: "h-4 w-4 ...") %> <%= @text %>
  """
end

But getting lots of warnings.

from heroicons_elixir.

I think you make a good point @soundmonster @joefreeman I'll cut a new version without the warnings

from heroicons_elixir.

I deprecated the function versions of the components in favor of the Phoenix components - which achieves what your icon wrapper does

You can now use <Heroicons.Outline.foo> as a Phoenix component in your code directly

I noted this in the readme but this is a good nudge to keep a change log and make the deprecation warning tell you what to do

Keeping this issue to track that

from heroicons_elixir.

Oh! That's my bad for not reading better. Thanks for pointing that out and thanks for the quick response! <3

from heroicons_elixir.

I deprecated the function versions of the components in favor of the Phoenix components - which achieves what your icon wrapper does

You can now use <Heroicons.Outline.foo> as a Phoenix component in your code directly

I noted this in the readme but this is a good nudge to keep a change log and make the deprecation warning tell you what to do

Keeping this issue to track that

Thanks for the response. I have a minor doubt: what if we want to reuse common class, it seems not easy to wrap <Heroicons.Outline.foo> in a new component.

from heroicons_elixir.

Having a way to parameterize the icon was very handy and feels like a valid use case, e.g. for generating navigation links.

from heroicons_elixir.