Mix script to update SVGs from Github about heroicons_elixir HOT 7 CLOSED

Completely forgot about this, remembered now that Heroicons 2 is getting released. I'm on holiday away from the computer but when I get back, start of the next week I'm creating the PR. There is a new type of icons now too, Mini.

from heroicons_elixir.

❤️ thanks for this!

I like the idea of downloading the heroicons during build, fixed to a version. What do you think of following the pattern in https://github.com/phoenixframework/esbuild to do that?

Yep, think that is a great idea. :)
Why did I think about implementing this? Because they are releasing a new version of the icons (overhaul) and thought about making it simpler to update.
Thanks, I'll work on the commit and submit a PR for your review. :)

👍

from heroicons_elixir.

@mveytsman Think we can close this issue, right? Great job on the cache by the way, that's a nice idea for runtime generation! 👍

from heroicons_elixir.

Right now this only runs through a mix task, so only useful for publishing new versions.
We can maybe build on this to update the version / icons when building the dependency.

from heroicons_elixir.

❤️ thanks for this!

I like the idea of downloading the heroicons during build, fixed to a version. What do you think of following the pattern in https://github.com/phoenixframework/esbuild to do that?

from heroicons_elixir.

@mveytsman I've been working a bit on this this weekend to create the PR (sorry for the delay, lots of work recently).

I have some doubts about how to tackle this.
Right now I have a mix task to update the icons fixed to a version, useful either for packaging a new release.
This is a bit different than :esbuild since in :esbuild you can also run mix esbuild.install to install it and/or you need to add esbuild to phoenix watchers (in development) in order to call install_and_run ( esbuild: {Esbuild, :install_and_run, [:default, ~w(--sourcemap=inline --watch)]}.

Now... we don't need to have an application running, do we? So our use case is a bit different, we can just have the update mix task as :esbuild has the install mix task.

In order to download the version configured by the user at build time to override the files packaged in /priv, is that even possible? Maybe some sort of post install hook?, I don't know a way to do that other than to override mix deps.get in the mix aliases but that is userland, anyway.

So my conclusion for now at least is we can do with just the heroicons.update mix Task. Any ideas?

Thanks!

from heroicons_elixir.

@greven I see what you're saying. Can you make a PR and I'll review it ?

from heroicons_elixir.