murgatt / recode-converter Goto Github PK

Describe the bug
A fatal JavaScript error appears when starting conversion after the window has been closed (app is not closed).

A JavaScript error occurred in the main process
Uncaught Exception: Error: Object has been destroyed

To Reproduce
Steps to reproduce the behavior:

1. Start the app and close the window (don't quit the entire app).
2. Select at least one file.
3. Start the conversion
4. A fatal JavaScript error appears

Expected behavior
There should not be any error (obviously).

Desktop (please complete the following information):

• OS: macOS

Describe the bug
A conversion error occurred when the conversion list contains multiple files from different directories and the destination is set as "Same as source"

To Reproduce
Steps to reproduce the behavior:

1. Add at least two files from two different directories
2. The destination should not be set manually and should be "Same as source"
3. Start the conversion
4. Conversion error

Expected behavior
Conversion should not fail

Desktop (please complete the following information):

• OS: all
• Version 1.1.0

Describe the bug
When we add file(s) from a directory, destination field should displayed the default destination path and it should be the same as the source(s) directory.
But nothing is displayed

To Reproduce
Steps to reproduce the behavior:

1. Open app
2. Import at least one file from a directory
3. Destination input is empty

Expected behavior
Default destination path should be displayed in the destination input.

Screenshots

Desktop (please complete the following information):

• OS: Windows
• Version 0.2.0

Describe the bug
When a file is added during a conversion, the conversion is still in progress after it finish.

To Reproduce
Steps to reproduce the behavior:

1. Open the app and and one or multiple files to convert
2. Start the conversion
3. Add a file during the conversion
4. When the conversion is finished, the app is still in the conversion progress state

Expected behavior
When the conversion is finished, the app should be in the conversion end state even if a file has been added during the conversion.

Screenshots

Desktop (please complete the following information):

• OS: all
• Version 0.3.0

Additional context
To fix: prevent adding files during conversion or conversion list should not be the same list as file list

Describe the bug
You can clear the file list during a conversion.
The behavior is not desired and it causes a console error

To Reproduce
Steps to reproduce the behavior:

1. Start a conversion
2. Clear file list during the conversion
3. There is a console error

Expected behavior
You can't clear list during a conversion

Desktop (please complete the following information):

• OS: all
• Version 12.0

Describe the bug
When multiple files have been added to the file list, it is impossible to add back one file after delete it.

To Reproduce
Steps to reproduce the behavior:

1. Start the app and select one file to add
2. In the file list, add another file.
3. Remove this file and try to add it back
4. The file cannot be added

Expected behavior
The file should be added back and appear in the file list.