Git Product home page Git Product logo

Comments (11)

Munter avatar Munter commented on July 17, 2024

I need to write done tests :(

from hyperlink.

bebraw avatar bebraw commented on July 17, 2024

I think it had something to do with my Node version since Travis gave proper errors. I've fixed them since. But yeah, let's leave this open. 👍

from hyperlink.

Munter avatar Munter commented on July 17, 2024

No, there are proper errors in there. I'm diving into it now. Might have uncovered some paths in assetgraph that usually don't get exercised

from hyperlink.

Munter avatar Munter commented on July 17, 2024

Fixed in 2.6.0

Also found 6 new errors in your code base with it :)

from hyperlink.

bebraw avatar bebraw commented on July 17, 2024

Just updated. Getting

Error: Cannot find module './assetNodeOffsetDescription'
    at Function.Module._resolveFilename (module.js:455:15)
    at Function.Module._load (module.js:403:25)
    at Module.require (module.js:483:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (.../webpack.js.org/node_modules/hyperlink/lib/index.js:7:34)

for some reason (tried with fresh install of hyperlink too). It might be missing some file based on the error.

from hyperlink.

bebraw avatar bebraw commented on July 17, 2024

It's definitely missing ./assetNodeOffsetDescription from the released version (tried a standalone project). The problem has to do with files. Change lib/index.js to lib to fix.

from hyperlink.

Munter avatar Munter commented on July 17, 2024

Oh dear. Too restrictive package.json files :(

from hyperlink.

Munter avatar Munter commented on July 17, 2024

Fixed in 2.6.1

from hyperlink.

bebraw avatar bebraw commented on July 17, 2024

Thanks! Works great.

from hyperlink.

Munter avatar Munter commented on July 17, 2024

Actually the errors you are getting about not being allowed to have digits first in an id are wrong. Jut did some research on it. I'll update the hyperlink behavior to not report that as an error

from hyperlink.

bebraw avatar bebraw commented on July 17, 2024

Alright. Fixed anyway. 👍

from hyperlink.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.