Comments (2)
Fetch had always been difficult to reason about for assetgraph. There's are cases where it's used to fetch internal static assets, which would make sense to check, and in assetgraphs other user cases to include in the build. But this case is obviously wrong behavior, and hyperlink also shouldn't attempt other http methods either.
I'm inclined to say that hyperlink should maybe just assume fetch is not used for static content by default, and not check the link at all.
It maybe it should only follow fetch requests if the URL had a known static file extension.
@papandreou what do you think?
from hyperlink.
I think we should stop modelling fetch
And let users opt in with fetch(β/foo.jsonβ.toString(βurlβ))
.
from hyperlink.
Related Issues (20)
- BUG: Checks pages outside its boundaries
- Follows links to canonicalRoot instead of resolving as local HOT 1
- Doesn't recognize fragment links to name attributes
- An in-range update of eslint-config-standard is breaking the build π¨ HOT 3
- Fails when a directory-name has an @ symbol HOT 1
- Netlify build fails early with no info HOT 3
- embed src causes internal traversal to extend to foreign domain HOT 2
- False negatives HOT 4
- Security vulnerability in deprecated package HOT 2
- mark whole run as `--todo` HOT 4
- Can I mark a file/node to be ignored? HOT 6
- Memory leak issue during checking of all links
- Feature request: garbage collection / dead file detection HOT 7
- Update assetgraph to remove vulnerable dependency HOT 2
- Exits badly (stack trace) on some external links HOT 10
- Document dependency on 'file'/'libmagic1'? HOT 5
- img src ignores ``--internal`` HOT 1
- Mistaken "not ok" links HOT 2
- Remove dependency on deprecated request package HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hyperlink.