munierujp / aws-lambda-ts-architecture-example Goto Github PK

Add get method (private method) to UserRepository (src/interfaces/dynamodb/UserRepository.ts) and use it in findById method.

export class UserRepository implements repositories.UserRepository {

  async findById (id: string): Promise<User> {
    const user = await this.get({ id })
    return user as User
  }

  private async get (key) {
    const result = await this.db.get({
      TableName: this.tableName,
      Key: key
    }).promise()
    const item = result.Item

    if (item === undefined || isEmpty(item)) {
      throw new UserNotFoundError('user not found')
    }

    return item
  }
}

Before

in src/usecases/userGetter.ts:

import type { User } from '../domain/models'

in test/usecases/userGetter.test.ts:

import type { User } from '../../src/domain/models'

After

~ is alias for root dir.

in src/usecases/userGetter.ts:

import type { User } from '~/domain/models'

in test/usecases/userGetter.test.ts:

import type { User } from '~/domain/models'

specify the npm version that corresponds to the Node.js version.

cf. https://qiita.com/hirorock/items/3a98a43f38aec39aab4f

The name "Interfaces" is the same as TypeScript's Interfaces, which is confusing.

Follow RFC 7807 as error response format

replace tsconfigs to @tsconfig/node12

update Node to v14.17.0

https://docs.aws.amazon.com/lambda/latest/dg/lambda-nodejs.html

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

Error type: undefined. Note: this is a nested preset so please contact the preset author if you are unable to fix it yourself.

Before

import { userGetter } from '../usecases'

const executor = new userGetter.Executor({
  userId,
  userRepo
})
const result = await executor.execute()

After

import { UserGetter } from '../usecases'

const userGettter = new UserGetter({ userRepo })
const result = await userGettter.get(userId)

https://eslint.org/docs/user-guide/configuring/ignoring-code#the-eslintignore-file

Add test for validation in test/handlers/users_userId.test.ts

https://github.com/munierujp/aws-lambda-ts-architecture-example/community/license/new?branch=master&template=mit

This issue provides visibility into Renovate updates and their statuses. Learn more

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• chore(deps): update jest monorepo (minor) (@jest/types, @types/jest, jest)
• chore(deps): update node.js to v14.19.2
• chore(deps): update jest monorepo (major) (@jest/types, jest, ts-jest)
• Click on this checkbox to rebase all open PRs at once

• Check this box to trigger a request for Renovate to run again on this repository

remove lambda-tester

Before

const userRepo = new UserRepository({
  db,
  tableName: 'users'
})

After

const userRepo = new UserRepository(db)