Git Product home page Git Product logo

mumble-theme's Introduction

NOTE: This theme has been integrated into the Mumble main repository and thus this repository is no longer maintained.


A Mumble theme in Lite and Dark variants, which is distributed as the default skin in the Mumble client.

This theme is a derivative of the MetroMumble skin.

Skinning

Do not modify the qss files directly. Read below.

To change icons and other graphics, simply change the SVG files of the theme (with an editor such as Inkscape or Adobe Illustrator).

See the wiki article on Mumble skinning.

The theme is written in Sass, a language that processes into CSS (or QSS in this case).

If you want to make your own skin based on it, install a Sass processor such as Prepros. A Prepros project file is included, so simply add the mumble-theme folder as a project. If you are on Linux you can instead install ruby-sass in order to get access to the sass CLI program. With it you can compile the individual variants as (assuming you are currently inside the source directory)

sass -t expanded Lite.scss ../Lite.qss

The file source/Imports/Base Theme.scss contains the actual theme QSS, but it is not recommended to modify.

In future versions you might want to swap Base Theme.scss to a newer version, so it will be easier to update your theme in the future if you leave it alone.

Instead, you should edit either the Lite.scss or Dark.scss files in the source folder, and add your own CSS at the end of the file.

You can also add your own variants in the source/Imports folder, which contain the color definitions.

When you process these files in Prepros, it will output the complete skin to the qss files in the parent folder. If something didn't work out quite right, it can also happen that Prepros will output css files in the source folder. In that case you can simply replace the qss files in the root folder with the generated css files (the syntax is actually the same - only the file extension differs).

The OSX variant can also be found in the source folder, which imports the regular source files but adds a small OSX fix and modifies font sizes.

Have fun!

mumble-theme's People

Contributors

davidebeatrici avatar dexgs avatar hacst avatar kissaki avatar krzmbrzl avatar mkrautz avatar xpoke avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

mumble-theme's Issues

Fonts and font sizes on OS X

The fonts and font sizes need an overhaul for OS X.

We probably want to use the system font to fit in better -- unless we want to use the same Free font on all systems? @xpoke?

We probably want something like

font-family: ".SFNSDisplay-Regular", HelveticaNeue, LucidaGrande;

for OS X. (Per http://furbo.org/2015/07/09/i-left-my-system-fonts-in-san-francisco/)

For font sizes, we probably want something like this:

http://apple.stackexchange.com/questions/20898/what-is-mac-os-x-lions-finder-font/20910#20910

For reference, right now things look like this:

image

image

Sass variable usage

While trying to use this theme as the basis for my own variant, I came across a rather annoying issue: abuse of variables.

Example:

QCheckBox::indicator:focus:hover,
QTreeView::indicator:focus:hover,
QRadioButton::indicator:focus:hover,
QComboBox:focus:hover
{
	background-color:$button-focus-hover-bg;
	border-color:$button-focus-hover-border;
}

The naming suggests that $button-* variables are used for buttons, but they are used for many other components as well.

This leads to a situation where changing the appearance of buttons affects a dozen other elements in not predictable ways and I have to override a ton of style definitions if I follow the suggestion to not modify Base Theme.scss.

This is especially annoying since the design I'm trying to build uses a highlight color for buttons and that highlight color pops up in a dozen other places which are not supposed to be highlighted.

I'd suggest to stop using $button-* variables for anything other than buttons and introduce corresponding $input-* variables instead so the design is basically split into "buttons" and "all other input elements" just like many of today's CSS frameworks do.

Drop version definition in `overlay.mumblelay`

The file overlay.mumblelay contains a version string at

version=1.4.0
.

This may be a technical necessity, but it is very bad architecture because now the Mumble version depends on the themes layout file.

It makes version bumps in Mumble more complex and error prone. mumble-voip/mumble#3799 mumble-voip/mumble#3761

If at all possible the theme must not contain version specific code like this.

@xpoke Is the assumption correct that this is a layout file replacing the existing one for layout changes. And the version number being in there is a side effect because we override the entire file?

So the way to fix this would then to look for a way in Mumble itself to clear it from the layout file? (What is the file used for and how?)

"Type message to channel" box

The box where text is typed should be white in the new theme. As it stands it just looks like some text on a background, whereas it should look like a separated area.

Help Icon

We maybe want to add a help icon in the configuration options, to show additional information (e.g. regarding echo-cancel etc.).
For a first concept see:
mumble-voip/mumble#4127 (comment)

Maybe someone could provide a good looking icon that is also consistent with the overall theme.

Taskbar icon obviousness

Copy-paste from IRC:

the taskbar icon is awful as someone who is colour-blind
cannot tell the difference between talking and not whatsoever
it's easy to tell in mumble itself due to the white background, the "waves" next to the person are obvious
I think I'd rather it be the actual mumble icon when not talking
as a "person" while idle doesn't represent what kind of program it is
then have the talking guy when talking
that will make the difference pretty obvious

Write a documentation

As mentioned by @Kissaki here,

Although this may not happen now or ever, Iโ€™d love to see a design documentation that shows and describes the icons with argumentation why they are used, for a feature and in relation to others.

A documentation for all icons and their purposes & usecases would be very good.

Consider replacing `Unlicense` for media/theme assets.

https://github.com/mumble-voip/mumble-theme/blob/master/LICENSE

I'm a contributor to minetest and we've had similar discussions with many contributors about mods, themes, etc.. My conclusion is that Unlicense (or, any form of Public Domain declaration) is an unfit license for media/assets, and in general is problematic due to the statement that in jurisdictions where Copyright exists, the items are declared Public Domain, which may not exist at all in those jurisdictions. This leaves a gray area for interpretation where it may not at all be usable to some users.

For media and assets, we've found the CC licenses to be ideal. While personally I feel one should always, at minimum use CC-BY licenses, even CC0-1.0 would be a major improvement over Unlicense for media, as it spells out in detail what is permitted use.

Most important Ref.: https://opensource.org/faq#public-domain

Replace Ear icon

Suggested by @streaps here: #17 (comment)

It's about this icon:
https://github.com/mumble-voip/mumble-theme/blob/master/ear.svg

which is used for this (according to @Krzmbrzl ):

It marks listener proxies of the ChannelListener feature. Aka. this is a virtual ear that a user can drop into a channel in order to hear what is being spoken in it without having to join it.

It does not really look good at the moment, so maybe someone can improve or replace it.

Discuss ideas/changes below.

Use a different red tone of colour

Following the discussion in #31, I noticed that the red tone of colour is a bit too orange.
Visible for example here: https://raw.githubusercontent.com/mumble-voip/mumble-theme/master/muted_self.svg

I would like a darker and more red tone.

As far as I can see, the colour would need to be changed in the following files:

config_msgs.png
/exported/config_msgs.svg
deafened_self.svg
lock_locked.svg
muted_self.svg
/mimetypes/image-x-generic.svg
/emblems/emblem-favorite.svg
/actions/audio-input-microphone-muted.svg
/actions/format-text-bold.svg
/actions/media-record.svg

Theme variants using FontAwesome

Hey - It's been a while since I created the theme, but I saw you guys released 1.3 (!)

I was wondering if there's an interest in making variants using the icons from FontAwesome's GPL-friendly library.
https://fontawesome.com/
https://github.com/FortAwesome/Font-Awesome
https://github.com/FortAwesome/Font-Awesome/blob/master/LICENSE.txt

I specifically think some users would like a less colorful theme, and we can easily add high quality icons.
Let me know if this fits with your plans for a 1.3.1 release

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.