Using SIAC-V2.3.5 and GDAL 2.3.3 on a recent Sentinel 2 observation returns the following error: ... .jp2' not recognized as a supported file format.

This is returned after the following output: Doing per pixel angle resampling.

Do you have any suggestions on how to address this?

P.S. Thank you for contributing to open source EO tools. This has the potential to be quite useful for batch processing.

The atmospheric correction expects some of its auxiliary data (as the MODIS MCD43 files) to be placed in a single folder that is to be browsed. It would be good if it were possible to hand in the files directly, especially when these might be located in different folders.

@MarcYin
to have a cleaner 'Components' section in the core docs please lower the level of "Indices and tables"

from
Indices and tables

to
Indices and tables

@MarcYin
please add a file called "authors.rst" with your name (e.g. * Thomas weiß <"[email protected]">) in the main directory of this repository. I will link then this information to our main MULTIPLY documentation page

Hi @TonioF @gritk ,

This atmospheric correction method needs:

Sentinel 2 data downloaded from AWS on a tile basis, which is much more convenient and reasonable compared to how ESA save the Sentinel 2 data);
CAMS near real time prediction for each day at a time step of 3 hours with the start time of 00:00:00, and should contains aod550, tcwv and gtco3 parameters;
a global DEM VRT file;
MCD43 collection 6 data from 3 days before to 3 days after the sentinel 2 observations;
you will also need the emulators for Sentinel 2 bands, which can be found at http://www2.geog.ucl.ac.uk/~ucfafyi/
The executable file is called Sentinel_atmo_cor.py which can be used as: python Sentinel_atmo_cor.py /directory/where/you/store/s2/data/29/S/QB/2017/9/4/0/ . No other options are needed for this version yet. It will correct for all bands and save them into the same directory of TOA reflectance with the name as B0?_sur.tif and a TOA_RGB.tif and BOA_RGB.tif is also composed for vision checking.

Further details are referred to GitHub at https://github.com/multiply-org/atmospheric_correction

Thanks a lot,

Feng.

I used to work on atmospheric correction of Landsat 8 via this package. But I struggle in the problem like following.

from SIAC import SIAC_L8
import os

BASE_DIR = r"E:\Remote Sensing"

kwargs = dict(
    l8_dir=os.path.join(BASE_DIR, "Landsat", "LC08_L1TP_147031_20170515_20170525_01_T1", ""),
    mcd43=os.path.join(BASE_DIR, "MCD43", ""),
    vrt_dir=os.path.join(BASE_DIR, "MCD43", ""),
    global_dem=os.path.join(BASE_DIR, "eles", "global_dem.vrt"),
    cams_dir=os.path.join(BASE_DIR, "cams", "")
)

if __name__ == "__main__":
    SIAC_L8(**kwargs)

2020-02-12 08:17:27,591 - SIAC-2.3.0 - INFO - Starting atmospheric corretion for E:\Remote Sensing\Landsat\LC08_L1TP_147031_20170515_20170525_01_T1
...
...
...
2020-02-12 09:47:18,612 - SIAC-2.3.0 - INFO - Doing corrections.
Traceback (most recent call last):
  File "C:\Users\tcztzy\Documents\GitHub\multiply-org\atmospheric_correction\main.py", line 15, in 
    SIAC_L8(**kwargs)
  File "C:\Users\tcztzy\Documents\GitHub\multiply-org\atmospheric_correction\SIAC\SIAC_L8.py", line 44, in SIAC_L8
    aero_atmo = do_correction(*ret)
  File "C:\Users\tcztzy\Documents\GitHub\multiply-org\atmospheric_correction\SIAC\SIAC_L8.py", line 122, in do_correction
    atmo._doing_correction()
  File "C:\Users\tcztzy\Documents\GitHub\multiply-org\atmospheric_correction\SIAC\the_correction.py", line 590, in _doing_correction
    ret = self._get_boa()
  File "C:\Users\tcztzy\Documents\GitHub\multiply-org\atmospheric_correction\SIAC\the_correction.py", line 431, in _get_boa
    re = list(map(self._do_chunk, bands_to_do))
  File "C:\Users\tcztzy\Documents\GitHub\multiply-org\atmospheric_correction\SIAC\the_correction.py", line 464, in _do_chunk
    toa = toa * self.ref_scale + self.ref_off
ValueError: operands could not be broadcast together with shapes (7931,3910) (7931,7821)

conda create -n siac
conda install -n siac -c conda-forge -c f0xy siac
...
Downloading and Extracting Packages
siac-2.3.1           | 10.2 MB   | ########################################################################### | 100%  
ChecksumMismatchError: Conda detected a mismatch between the expected content and downloaded content
for url 'https://conda.anaconda.org/f0xy/noarch/siac-2.3.1-0.tar.bz2'.
  download saved to: C:\Users\tcztzy\scoop\apps\miniconda3\current\pkgs\siac-2.3.1-0.tar.bz2
  expected md5: 64188e31f1537075cf02e64e269023c6
  actual md5: 84c7875dcd76c36a9cead4ba7e267db0

And I use my web browser download url 'https://conda.anaconda.org/f0xy/noarch/siac-2.3.1-0.tar.bz2'

$ md5sum /mnt/c/Users/tcztzy/Downloads/siac-2.3.1-0.tar.bz2
84c7875dcd76c36a9cead4ba7e267db0  /mnt/c/Users/tcztzy/Downloads/siac-2.3.1-0.tar.bz2

@MarcYin
For consistency please change the documentation name for the repository to
MULTIPLY - Sensor Invariant Atmospheric Correction (SIAC)

As the title said. When you clone the source code on Windows, the pickle file's end line will replace by '\r\n' by default, which will cause the error while loading. Adding a file named .gitattributes with content like following will solve this problem.

*.pkl binary

Numpy 1.18 introduce this PR. And this PR will cause the problem as I reported.

As the title said, maybe I can contribute.

I used to suffer the exceptions as the title said. I personally think if a nested function doesn't relay on the local variable of the parent's scoop, put this function on the top scoop is the better way.
Python: AttributeError: Can't pickle local object 'writeBuf..write'
Can't pickle function

I used to install SIAC with pip, things worked fine before the process handling MCD43_VRT, I got the error message as "None object has no attributes named FlushCache", the detailed log message shows that it failed getting VRT files from HDR. The latest release of gdal in pypi is version 3.0.3, I downgrade gdal to 2.4.4, such problems solved.