mukaba / portfolio_microverse Goto Github PK

-- Use a consistent naming convention for classes, such as lowercase with hyphens or camelCase, to improve readability and maintainability.
-- Use rem or em units instead of px units to make the layout more flexible and responsive on different screen sizes and devices.
-- Add comments to explain the purpose of each section of the code, especially if it is complex or hard to understand.
-- Use vendor prefixes for browser-specific properties to ensure compatibility with older browsers.
-- There's a missing arrow in Language (About Myself section). I think it will be great if you add it.

Hello @Mukaba you have done a good job,

But I have identified an issue in your code where the code is not working as expected. After debugging, I have determined that the code is not going to close the popup menu. Actually you're using the identifier to close the popup which is not declared before. You can see it here.

Proposed Solution: You can declared identifier with following name
const popClose = document.querySelector('.closePopup');

Hope it works for you😊

1- Contact me section :

• Button Color should match Figma design.
  2- About myself section :
• Missing arrow beside language
  3- works section:
• replace images for desktop version.

• Suggestions

• All project export background image from figma to replace the divs in html.
• Add menu nested inside Nav rather than background image.

Every thing else in the project is fine and nice.
Thanks Jean.