Comments (2)
This is a valid issue but to properly solve it, it seems like we might have to use a proper color string parser (that might be used in libraries like lightningcss) instead of relying on simple regex patterns, which we are doing right now. This will increase the bundle size when using @mui/system
but will definitely help with Pigment CSS. I'll see if there is something that can be done for both.
Edit: This is in lightningcss that only handles color related features. Whole file might not be doing it but it's still a lot of cases to handle something that is not the core functionality of what we provide.
from material-ui.
Update here—it seems it could only be a syntax matter:
hsl(212 19 15)
doesn't workhsl(212 19% 15%)
doesn't workhsl(212, 19%, 15%)
works! ✅
Even though this solves my immediate problem for now, I think it might still be worth keeping the issue up, as all of these syntaxes are valid CSS (I'm just not 100% sure about the second option, though, with units and not commas—MDN doesn't mention it) and should be supported.
from material-ui.
Related Issues (20)
- [docs] Confusion around package managers HOT 6
- [docs-infra] Implement debounce to reduce number of requests sent to Algolia during search HOT 7
- Upgrading from `6.0.0-alpha.7` to `6.0.0-alpha.8` breaks styles of TextField HOT 1
- [material-ui][Autocomplete] Slow performance with `renderOption` having Checkbox HOT 1
- (material-ui@next) MUI InputLabel shrink state is bugged HOT 2
- [docs-infra] Overflow in API view on mobile HOT 1
- Responsive App bar with Drawer not working as intended? HOT 2
- [material-ui] How to properly merge themes that are using styleOverrides functions? HOT 2
- [RFC]
- [material-ui][Table] How to insert a row after a row and before a row on current page HOT 3
- [material-ui][Autocomplete] Listbox opens and closes on click when used with `limitTags` HOT 1
- [material-ui] Questions regarding Pigment CSS usage HOT 4
- [icons] Support getting Icon Components as Arrays, by styles and tags HOT 2
- [material-ui][docs] Bug with keyboard navigation in Select HOT 11
- [core] Remove enzyme HOT 1
- [material-ui] Lazy-loaded Collapse with unmountOnExit causes infinite loop HOT 8
- [material-ui] Not able assign React query fetched data to nested array HOT 2
- [mui-material][mui-system] Drop support for Safari < 14 HOT 3
- [docs] Release docs with latest version HOT 1
- [material-ui] Prop className did not match with Next.js HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material-ui.