Git Product home page Git Product logo

Comments (7)

LalitDeore avatar LalitDeore commented on September 27, 2024 1

Thank you @aarongarciah. I have achieve that behaviour with the reducing number of request sending to alogolia wihout harming the user experience. I am going to make PR for this let's see result in the PR.

from material-ui.

LalitDeore avatar LalitDeore commented on September 27, 2024

Hey, @zannager I want to work on this issue. Can i work on this issue?

from material-ui.

aarongarciah avatar aarongarciah commented on September 27, 2024

@LalitDeore we should only reduce network requests if it results in a better (or equal) user experience. The current search is very snappy so any change we introduce shouldn't impact user experience negatively.

Would the changes you have in mind improve the user experience somehow?

from material-ui.

LalitDeore avatar LalitDeore commented on September 27, 2024

Hey @aarongarciah, I believe that reducing the number of network request will not reduce the User Experience when i search for query like "components" than i am expecting the result when i end the typing i don't want it to see result for each character i am entering. I am thinking it to send only one request when user end typing means query is enterd than get the result for that query. What's your thaught on this?

from material-ui.

aarongarciah avatar aarongarciah commented on September 27, 2024

I think waiting until the user stops typing will probably result in a worse experience. Currently, when you type "bu" you already see "Button" as the first result, which I'd say is what most users would expect.

Screenshot 2024-05-29 at 16 22 31

I don't want to discourage you from experimenting but at the same time, I want to set clear expectations. I'm closing this issue since I think there's nothing to act on.

from material-ui.

LalitDeore avatar LalitDeore commented on September 27, 2024

I think you might not get the what i want to do here. when you type "bu" than you sent the 2 request to algolia but we need just one request to get the result of the "bu". User don't need enter the complete query to get the result of the "button". even user just stop typing with incomplete query than we will get the same result as you see there. i was thinking to reduce the just number of request sending to algolia for one query it doesn't matter if query is complete or not. For example if i type "component" than i don't want to send 9 request for just one query. if i type just "comp" than i don't need to send 4 request just one request is sufficient to get the result of the "comp" or "component" with this result will be same as multiple request or just one request we are sending. But if you think it will not work it's okay to close.

from material-ui.

aarongarciah avatar aarongarciah commented on September 27, 2024

Thanks for the explanation, I understood it correctly. The thing is, we want to show results as quickly as possible i.e. when I'm writing "button", we want to display results even if the user has only typed "bu" and even if the user keeps writing the rest of the word. I hope that makes sense.

Feel free to open a PR if you think you can achieve a nice user experience, but if the final experience means users don't get results until they stop typing, I'm afraid we won't be happy with that experience and the PR might be rejected.

from material-ui.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.