Polygon.getPortalEdge left/right confusion about yuka HOT 4 CLOSED

Yes, the current nomenclature is a bit confusing. The edges of a polygon are defined in CCW order where HalfEdge.vertex represents the head or destination vertex of the respective (full) edge. So considering you are standing inside the polygon and look outside, the left/right vertices of a portal edge are twisted. It's correct if you look from outside the polygon onto the edge.

When I remember correctly we did this because the algorithm in Corridor expects this kind of definition. If you change the code in Polygon.getPortalEdgeTo() to

portalEdge.left = edge.vertex;
portalEdge.right = edge.prev.vertex;

the result of Corridor is not correct anymore. So this class needs a fix too.

Additionally, maybe getPortalEdgeTo is not very useful generally, and maybe it should just be something more generic like getEdgeTo():HalfEdge, since it appears getPortalEdgeTo is only used by Navmesh and may be better off being used within NavMesh class only instead.

Let me think about this one a bit^^. Right now, it seems shifting the method to NavMesh is the most clear solution.

from yuka.

Right now, it seems shifting the method to NavMesh is the most clear solution.

Done! 91f7367

from yuka.

Perhaps, you should document about the portal data structure and what is "right"/"left" exactly according to certain conventions and make it consistent.

Added some comments via 774d48c. Things should be hopefully more clear now.

from yuka.

@Glidias Thanks for your valuable feedback! 👍

from yuka.