Git Product home page Git Product logo

Comments (5)

alamboley avatar alamboley commented on May 27, 2024 1

It seems it's ok 👍

from yuka.

Mugen87 avatar Mugen87 commented on May 27, 2024

I always use rollup for my builds. When using imports like below, the bundler correctly performs treeshaking and only includes into the build file what is actually necessary.

import { AStar, Graph, GraphUtils, NavEdge } from "yuka";

Can you please ensure that Webpack does not treeshake when using the global import?

from yuka.

Mugen87 avatar Mugen87 commented on May 27, 2024

Module not found: Error: Can't resolve 'yuka/src/graph/search/AStar'

Maybe it's because of this line:

src

That will ensure that no src directory is present in the npm package.

However, I do not like the approach of adding source files to the npm package since treeshaking shouldn't make this necessary. I'm also not a fan of explicit imports like import { AStar } from "yuka/src/graph/search/AStar"; since they easily break if the location of the source file changes. Devs shouldn't be aware of the source's code internal structure of a npm package.

from yuka.

alamboley avatar alamboley commented on May 27, 2024

Glad to know it should be done automatically.

Unfortunately, in babylon, I've to precise each path import { ArcRotateCamera } from "@babylonjs/core/Cameras/arcRotateCamera"; otherwise doing import { ArcRotateCamera } from "@babylonjs/core"; import the whole package. I can easily check with the output file size. Not sure how to check in the exported bundle if yuka is full or not.

from yuka.

Mugen87 avatar Mugen87 commented on May 27, 2024

Try to import a single class without dependencies like State. The bundle should contain no other Yuka classes.

from yuka.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.