muffix / couleurbummel Goto Github PK

Is there an existing issue for this?

• I have searched the existing issues

This is not a data update request

• I am not requesting a data update

Is your feature request related to a problem?

No response

Describe the solution you'd like

Die vorherige Version funktionierte zwar rudimentär ohne Googlekrebs, man mußte lediglich auf die Karte bzw. Umgebungssuche verzichten, aber in der jetzigen Version funktioniert keine einzige Funktion des Programms.

Bei Freigabe von Googleverbindungen bekommt man eine Standardgooglemapskarte angezeigt, die anderen Funktionen bleiben weiterhin ohne Funktion.

Und zu guter letzt wird auch noch frech eine Sicherheitswarnung angezeigt, das Programm könne nicht verifiziert werden und man möge es doch aus dem Play Store herunterladen.

Eine Version ohne jegliche Googleabhängigkeiten wäre sehr ordentlich.

Alternatives considered

No response

Additional context

No response

Is your feature request related to a problem? Please Describe.

The bubble background should be dark, but is actually light.

Despite allowing arbitrary views, the callout bubble that drawn by react-native-maps does not seem to allow for a customisation of the border colour. It remains white even in dark mode. We can make the background dark, but it doesn't look right with a white border.

Describe the solution you'd like

Ideally, react-native-maps would allow us to customise the border colour.

Alternatively, we can completely replace the bubble with a custom view by setting the tooltip prop. This allows for completely custom views, including self-drawn bubbles.

Describe alternatives you've considered

Apply the (presumed to be) correct styling to the callout, but the border remains white.
Additional context

It seems that the colour is hard-coded and cannot be overridden in React: https://github.com/react-native-maps/react-native-maps/blob/c447dea5eb4551440b131e3003ac50e0c5709fa9/ios/AirMaps/Callout/SMCalloutView.m#L607

Is your feature request related to a problem? Please describe.

Test coverage is currently somewhat limited and focuses mostly on snapshot and additional manual testing. This makes it difficult to tell whether the app is working as expected.

Describe the solution you'd like

We should introduce further tests, especially around user interaction with the app. This will also make it easier to review external contributions.

Describe alternatives you've considered

N/A

Additional context

Is there an existing issue for this?

• I have searched the existing issues

Happening on the latest app version?

• I have seen this on the latest version of the app

This is not a data update request

• I am not requesting a data update

Explain what you did

Ich habe die App auf einen Custom ROM ( Google Pixel 5a mit Graphene OS) ohne SafetyNet ( CTS profile match failed) installiert.

Describe the bug

Leider kommt es dann zu einer Fehlermeldung, dass die Integritätsprüfung nicht erfolgreich sei und die App lässt sich nicht vollständig nutzen (nur die Map wird angezeigt).

Expected behaviour

Wenn die Safetynet überprüfung deaktiviert wird, sollte die App auch auf nicht offiziellen ROMs problemlos laufen. *

Safetynet selber ist selber auch keine starke Attestierung, da diese sich relativ leicht fälschen lässt. So ist es beispielsweise möglich bei einem gerooteten ROM mithilte von Magisk und dem Modul UniversalSafetynetFix die Safetynet API so zu manipulieren, dass Safetynet immer funktioniert.

Eine deutlich sichere alternative zur Integritätsprüfung bei Andorid wäre die hardware basierte Integritätsprüfung. Diese ist im Gegensatz zum Safetynet oder dessen Nachfolger der GooglePlay zertifizierung unabhängig von Google. So könnte man auch vertrauenswürdige ROMs von drittanbierten zulassen.
Link zum nachlesen

Da es sich hier um keine Banking oder Bezahl App handelt ( welche hohen Sicherheitsanforderungen erfüllen müssen), denke ich dass eine Integritätsprüfung des ROMs für die Couleurbummel App nicht notwendig ist.

* habe das gleiche Problem auf einem andern Custom ROM gehabt, nach dem die SafetyNet Prüfung gefälscht wurde, funktionierte die App ohne Probleme.

Steps to reproduce

.

Your device and OS

.

Screenshots

Is there an existing issue for this?

• I have searched the existing issues

Happening on the latest app version?

• I have seen this on the latest version of the app

This is not a data update request

• I am not requesting a data update

Explain what you did

I restarted the app after previously navigating to a screen other than Map.

Describe the bug

The navigation drawer is highlighting the wrong screen. This is because we're persisting the state to storage:

When restarting the app, we are restoring the state for the navigation, but aren't respecting it for the content. We should do one of the following:

• remove the last selected screen from the persisted state and keep it only for as long as the app is running; meaning the app will always start on the Map screen
• restore the state fully and start on the last selected screen

Expected behaviour

The navigation drawer should highlight the correct item for the screen shown.

Steps to reproduce

1. Start the app
2. Navigate to any screen other than Map
3. Force-close the app
4. Reopen the app
5. Open the navigation drawer
6. Observe that the app starts on the Map screen, but the previously selected screen is highlighted in the navigation.

Your device and OS

Affects all devices, e.g. iPhone 12 Pro, iOS 16.2

Screenshots

Is there an existing issue for this?

• I have searched the existing issues

Happening on the latest app version?

• I have seen this on the latest version of the app

This is not a data update request

• I am not requesting a data update

Explain what you did

I tried to replace the component redefinition of the custom navigation with a reference to CustomDrawerContent directly. This works in the app, but the tests rendering the component are all failing with an "invalid hook call" message.

Describe the bug

Some project dependencies require conflicting versions of react. For example, react-native@npm:^0.70.6 requires [email protected], but we also have [email protected] in the package.json, which requires [email protected]. This can lead to inconsistent behaviour in tests because we have mismatching versions of react, potentially in use at the same time.

Expected behaviour

All dependencies should be unambiguous

Steps to reproduce

1. Replace `drawerContent={props => <CustomDrawerContent {...props} />}>` with `drawerContent={CustomDrawerContent}>`
2. Run tests
3. Observe the error

Your device and OS

Jest tests with the project Node version and dependencies as in 7d255154.

Screenshots

No response

Is your feature request related to a problem? Please Describe.

Currently, data change requests are submitted via e-mail and are applied manually. The data doesn't come in the right format and it's unclear what exactly is needed.

Describe the solution you'd like

We should provide a form in the app that allows users to submit data change suggestions to a backend. Submissions should be POSTed to a configurable endpoint. The submission must only include the object to be updated. If the request is to add a new corporation, it must contain all objects that are to be created. IDs for objects to be created must be included.

References (fields ending in ...Id) must be strings and must reference an object of the correct type.

Describe alternatives you've considered

A web form could be a good first step might be easier to achieve, but requires hosting.

Additional context

• Database schema: resources/couleurbummel.schema.json

Is there an existing issue for this?

• I have searched the existing issues

This is not a data update request

• I am not requesting a data update

Is your feature request related to a problem?

Die App beinhaltet aktuell leider keine Funktionalität fürs Ändern der Daten mehr

Describe the solution you'd like

Hi, wo findet sich denn die Sammlung der Adressen, die den eigentlichen Content ausmacht? Liegt da irgendwo im Sourcecode ein store, der das beinhaltet oder zieht sich die App das von einem Server?

Ich würde gerne eine Änderung an der Adresse vom K.St.V. Eckart zu Mannheim et Ludwigshafen vornehmen. Wir sind umgezogen und unser neues Haus findet sich in der Mundenheimer Straße 216 in 67061 Ludwigshafen am Rhein.

Alternatives considered

No response

Additional context

No response