mtreinik / alkuaanet Goto Github PK

If the user initiates audio playback and navigates to a new page before the playback is finished, the following message will be added to the console log:

Warning: Can't perform a React state update on an unmounted component. This is a no-op, but it indicates a memory leak in your application. To fix, cancel all subscriptions and asynchronous tasks in the componentWillUnmount method.
    in SongItem (created by WithStyles(SongItem))
    in WithStyles(SongItem) (at SongList.tsx:25)

Expected behavior: no console warnings.

The warning is a result of NoteAudioPlayer trying to call handleEndPlayback callback on a component that has already been unmounted, since the user has navigated away from the component before the playback was finished.

The same warning will be shown if requested playback hasn't started before user has navigated away from the component.

This could be fixed by adding function cancelPlaybackHandling, which would cancel the calling of currently pending handleStartPlayback and handleEndPlayback callbacks.

If the same song is added multiple times in the playlist, removing one instance of the song removes all instances of the song from the playlist.

This happens because songId is used to remove song from playlist.

Expected outcome: it should be possible to remove one instance of the song from the playlist, leaving other instances of the same song in the playlist.