mt-sre / devkube Goto Github PK

When parsing a file with a commented out kubernetes manifest, LoadKubernetesObjectsFromBytes throws an error that says Object 'Kind' is missing in 'unstructured object has no kind'.

I would expect the function to ignore commented lines.

I think it would be nice to have an update or patch function. Currently all we have is CreateAndWaitForReadiness that doesn't do anything if the call to Create returns an AlreadyExists error.

In the CreateAndWaitForReadiness function, create is called without any option set for FieldValidation, which defaults to Ignore. We should either set set the FieldValidation to at least "Warn" (I would prefer "Strict", unless anyone knows any downsides to this) or enable the ServerSideFieldValidation feature gate.

What do you think about adding these functions into dev kube?

func loadAndConvertIntoObject(scheme *k8sruntime.Scheme, filePath string, out interface{}) error {
	objs, err := dev.LoadKubernetesObjectsFromFile(filePath)
	if err != nil {
		return fmt.Errorf("loading object from file: %w", err)
	}
	if err := scheme.Convert(&objs[0], out, nil); err != nil {
		return fmt.Errorf("converting: %w", err)
	}
	return nil
}

func loadAndUnmarshalIntoObject(filePath string, out interface{}) error {
	obj, err := os.ReadFile(filePath)
	if err != nil {
		return fmt.Errorf("reading file: %w", err)
	}

	if err = yaml.Unmarshal(obj, &out); err != nil {
		return err
	}
	return nil
}

from https://github.com/openshift/addon-operator/blob/main/magefile.go#L1038