Add to path without inherit? about setup-msys2 HOT 5 CLOSED

I'm not sure to understand the use case. It feels like something you could add to .bashrc in a single step, after this action. Furthermore, you might execute that setup step only with MSYS2_PATH_TYPE=inherit, so you get access to all the envvars when setting up your custom paths.

Would you mind providing an example workflow where this feature would be used?

from setup-msys2.

Yeah, dumping things in .bashrc is probably the best workaround, and probably as good as an extra option to the action. just hoped to keep using existing code (with ::add-path::) if possible.

Running only one step with inherit is also an interesting suggestion, hadn't though of that.

https://github.com/3b/pngload/blob/ci/.github/workflows/test.yml is the workflow that inspired it. Switching to using .bashrc instead of ::add-path:: wouldn't be a big change, so I might just switch to that.

from setup-msys2.

In the reference workflow you linked, there is already an specific step for customizing the PATH on Windows. Hence, as you say, the change would be very small. Moreover, I believe it more "idiomatic" to avoid inherit as a default setting and, instead, add the custom locations to MSYS2's internal PATH rather than to the Windows PATH.

Should you need to have some custom locations added both in MSYS2 and on the Windows PATH, I'd suggest using ::add-path:: and .bashrc at the same time.

from setup-msys2.

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

from setup-msys2.

See https://github.com/umarcor/Surelog/blob/bec95782d6e44cbee8c7f4ce87c6e58716ddd0da/.github/workflows/test.yml#L89-L91 for an example about how to add a path to bashrc.

from setup-msys2.