Git Product home page Git Product logo

Comments (3)

eine avatar eine commented on June 3, 2024

It might, but it may not be desirable. Virtual environments provided by GitHub do include Git for Windows, which is added to the PATH by default. Incidentally, VSCode supports Git for Windows only, and they refuse to support MSYS2. I don't know whether a relation exists between both facts.

The point is that the default environment contains potentially conflicting tools, such as tar, git, ssh, etc. Unless we can guarantee that none of those is included in the minimal context, I'd prefer users to be aware that MSYS2 is strictly that: MSYS2/MINGW.

FWIW, an option is provided: https://github.com/msys2/setup-msys2#path-type

from setup-msys2.

lazka avatar lazka commented on June 3, 2024

https://github.com/msys2/MSYS2-packages/blob/915946a637e1f2b7e26e32782f3af322009293db/filesystem/profile#L28

It only adds those things which are in PATH on a fresh Windows install.

We should at least document the possible values and what they mean. I suspect various tools expect those directories to be in PATH, but I'm also not sure because I've never worked in such an environment.

from setup-msys2.

eine avatar eine commented on June 3, 2024

I picked your PR and modified it to change the default path-type to minimal. According to your last reference, I think it is an acceptable change for v1.2.0.

I suspect various tools expect those directories to be in PATH, but I'm also not sure because I've never worked in such an environment.

As a matter of fact, option path-type was added because some user needed it when using another action to setup golang: numworks/setup-msys2#13.

from setup-msys2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.