Git Product home page Git Product logo

portfolio's Issues

Peer to peer code review #4week

After reviewing your code
-The design is good it matches the figma template
-While clicking on the hamburger the other sections should not be visible

Peer to peer code review

Very great effort, you did a very good job and we appreciate your efforts. however, we suggest that you follow these instructions:

Highlights
✔️ Good GitHub flow
✔️ Good pull request
✔️ Readme looks professional

Suggestions for changes

  • We realized you used a lot of pixels in your CSS file and we think that you should use more of the percentage to make it more responsive, an example can be found in the CSS file between, you can reference from the image below
    image

  • Your languages button specifically your ruby padding is not even like the other languages. We think you should add some padding to make it even like the other languages are.
    image

Peer-Peer code Review

We all did review the code and all came to an agreement that he should make some changes , that is :
1 . on the First card of the design he included the language which are not need .However they are not visible on the browser but in the code base they are available.

Bugs hide and seek

Kindly fix this bug:

  • At line 12 of your app.js file please change the fourMinu to fourMenu.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.