mrswitch / notification.js Goto Github PK

Right now checking permissions (on browsers that support it) returns a kind of binary response, either "granted" or "denied": https://github.com/MrSwitch/notification.js/blob/master/notification.js#L97

The problem with that is that there are cases where it's useful to differentiate why notifications are not currently allowed.

• If the user still hasn't either allowed or denied desktop notifications, then I want to request permission to show them notifications.
• If the user refused allowing desktop notifications then I don't want to bother them by asking for permission again.

I think Notification.permission could return these possible values (just as an example):

• unknown
• enabled
• disabled
• denied

Hello, the way your shim works disables the Native HTML5 Desktop Notifications in Firefox 22, i have written a small gist that should streamline the small differences i have discovered in the implementations of WebKit, Blink and Gecko.

https://gist.github.com/Asmod4n/6030828

Just random feedback, not working when:
Tested using mobile Chrome 46.0.2490.76
Android 5.0.1

But it works great when trying the demo using the default android "Internet" browser.
Curious on whether will it work if I have a web app wrap by android webview?
http://developer.android.com/reference/android/webkit/WebView.html

Anyway, this notification on mobile is super awesome.

Hi, thanks for the library. Can we have .close() take a time argument and execute after time passes? I tried window.setTimeout(n.close, 1000) and got a TypeError: Illegal invocation error. Probably has something to do with this:
https://developer.mozilla.org/en-US/docs/Web/API/Window.setTimeout#The_.22this.22_problem

This would be even better with Ubuntu Notification support.

http://developer.ubuntu.com/api/ubuntu-12.04/javascript/unity-web-api-reference.html#unity-notification

Bower could not to install the package.
Could you publish the one?

Is there any reason why you explicitly have the code:

this.onclick = function(){};
this.onclose = function(){};

instead of:

this.onclick = options.onclick || function(){};
this.onclose = options.onclose || function(){};

?

Can I play sound when receiving a notification?