mrmop / useragent Goto Github PK

Hi! I found myself hitting some crashes when using the Android version of this extension. These occur:
-On Exit
-When making multiple calls to getUserAgent()

The cause of this is that on line 57 of UserAgent_platform.cpp, the result of s3eEdkReallocOS() is not assigned into g_RetStr. This means that g_RetStr now points to free memory, which will cause subsequent calls to s3eEdkReallocOS() or s3eEdkFreeOS() to crash or misbehave.

It seems like the intent of line 57 was probably not this:
s3eEdkReallocOS(g_RetStr, g_RetStrLen);
...but instead to use this:
g_RetStr = (char *)s3eEdkReallocOS(g_RetStr, g_RetStrLen);

This seems to solve the issue for me!