Comments (13)
Made the pull request, figured out that in your lib the connection is made directly, was not the case, so my events where attached after and di not get the first one.
Thanks for the great work !
from ecovacs-deebot.js.
Yes, definitely fine ! I have work to do still on my side, and don't expect to publish before tonight, so take your time :)
from ecovacs-deebot.js.
@nicoduj @boriswerner
I just published version 0.4.5 on npm :)
from ecovacs-deebot.js.
thanks a lot !
from ecovacs-deebot.js.
Hi,
Hi Nicolas,
I am evelopping an homebridge plugin for deebots and there is an issue when you try to connect to the API twice from the same device, with consecutive attemps : I often get this error code on connection.
I have fixed this in the original sucks.js and did a pull request, but the maintainer is not there anymore and I would like to switch to your package but can't do any pull request on it since it is a fork also.
I appreciate that you want to use this library for your project 👍
You are also welcome to participate in this project and create pull requests.
Here is the original pull request : jeremy-green#1
I use uniqid dependency, and changed the following line :
params['requestId'] = EcoVacsAPI.md5(Number.parseFloat(Date.now() / 1000).toFixed(0));to
params['requestId'] = EcoVacsAPI.md5(uniqid());And then everything is good.
Thank you! I already made some tests and it seems to finally fix this issue.
That's good news 👍
Do you want to create a pull request for this fix?
from ecovacs-deebot.js.
Thanks for taking a look into it ! I have to delete my fork of original repo to fork yours will do I hope today.
I would also wonder why you did not use / populate a ready state like it was done in sucks.js ? I was using it in order to reconnect in case of disconnect (xmpp / mqtt).
Last but not least, on my first migration attemps I don't get events on my object , looking into it before a complete switch :)
from ecovacs-deebot.js.
Thanks for taking a look into it ! I have to delete my fork of original repo to fork yours will do I hope today.
I would also wonder why you did not use / populate a ready state like it was done in sucks.js ? I was using it in order to reconnect in case of disconnect (xmpp / mqtt).
ok, you did the implementation in this commit, right? I'll have a look at it.
Last but not least, on my first migration attemps I don't get events on my object , looking into it before a complete switch :)
ok 😉
btw: which Deebot model are you using?
from ecovacs-deebot.js.
I am working on the pull request, will submit my whole changes once I have something working. I use a deebot ozmo slim 10. IT is a code matter, since if i set the event in my api class, i get it , but when i retrieve vacbots objects through an array and set it on "top level", I d'ont. I think it is some changes from the new Vacbot() from original impl and your getVacBot function.
from ecovacs-deebot.js.
Is the Deebot Ozmo Slim 10 model using MQTT or XMPP as communication protocol?
from ecovacs-deebot.js.
MQTT
from ecovacs-deebot.js.
Great :-)
from ecovacs-deebot.js.
Can you tell me when you will publish on NPM ? i have bumped the verison in package.json. I will then be able to make my plugin depends on your package instead of my fork, it will prevent some installations errors ;p
from ecovacs-deebot.js.
Can you tell me when you will publish on NPM ? i have bumped the verison in package.json. I will then be able to make my plugin depends on your package instead of my fork, it will prevent some installations errors ;p
I'm planning to publish it within the next hour. ok?
from ecovacs-deebot.js.
Related Issues (20)
- Implementation of the ability to also use the yeedi API HOT 16
- Crash while trying to read undefined data HOT 9
- Are there anyway to connect to the Ecovacs Robot without login? HOT 1
- No "ready" event received HOT 2
- Waterbox info HOT 4
- CleanReport and CleanSum HOT 12
- Move Left Right MoveTurnAround ? HOT 18
- ioBroker Warn Message HOT 1
- GetCleanLog serving old logs HOT 10
- Custom logging function HOT 1
- vacbot.disconnect(); HOT 27
- AirFreshening / aromamode not working HOT 20
- Request failed with status code 502/504 HOT 3
- No error event fired for "Charging dock not found" HOT 7
- Shortcut Command to remove current Map or Restore Map Backup ??? HOT 1
- Map get lost working on backup image HOT 1
- GB/WW api endpoint not found HOT 1
- Retrieve values for air quality returns code 500 HOT 10
- Some feedback on testing with the X2 Omni. HOT 4
- is it support R96? HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ecovacs-deebot.js.