Git Product home page Git Product logo

Comments (13)

nicoduj avatar nicoduj commented on September 23, 2024 2

Made the pull request, figured out that in your lib the connection is made directly, was not the case, so my events where attached after and di not get the first one.

#28

Thanks for the great work !

from ecovacs-deebot.js.

nicoduj avatar nicoduj commented on September 23, 2024 1

Yes, definitely fine ! I have work to do still on my side, and don't expect to publish before tonight, so take your time :)

from ecovacs-deebot.js.

mrbungle64 avatar mrbungle64 commented on September 23, 2024 1

@nicoduj @boriswerner
I just published version 0.4.5 on npm :)

from ecovacs-deebot.js.

nicoduj avatar nicoduj commented on September 23, 2024 1

thanks a lot !

from ecovacs-deebot.js.

mrbungle64 avatar mrbungle64 commented on September 23, 2024

Hi,

Hi Nicolas,

I am evelopping an homebridge plugin for deebots and there is an issue when you try to connect to the API twice from the same device, with consecutive attemps : I often get this error code on connection.

I have fixed this in the original sucks.js and did a pull request, but the maintainer is not there anymore and I would like to switch to your package but can't do any pull request on it since it is a fork also.

I appreciate that you want to use this library for your project 👍
You are also welcome to participate in this project and create pull requests.

Here is the original pull request : jeremy-green#1

I use uniqid dependency, and changed the following line :

params['requestId'] = EcoVacsAPI.md5(Number.parseFloat(Date.now() / 1000).toFixed(0));

to

params['requestId'] = EcoVacsAPI.md5(uniqid());

And then everything is good.

Thank you! I already made some tests and it seems to finally fix this issue.
That's good news 👍

Do you want to create a pull request for this fix?

from ecovacs-deebot.js.

nicoduj avatar nicoduj commented on September 23, 2024

Thanks for taking a look into it ! I have to delete my fork of original repo to fork yours will do I hope today.

I would also wonder why you did not use / populate a ready state like it was done in sucks.js ? I was using it in order to reconnect in case of disconnect (xmpp / mqtt).

Last but not least, on my first migration attemps I don't get events on my object , looking into it before a complete switch :)

from ecovacs-deebot.js.

mrbungle64 avatar mrbungle64 commented on September 23, 2024

Thanks for taking a look into it ! I have to delete my fork of original repo to fork yours will do I hope today.

I would also wonder why you did not use / populate a ready state like it was done in sucks.js ? I was using it in order to reconnect in case of disconnect (xmpp / mqtt).

ok, you did the implementation in this commit, right? I'll have a look at it.

Last but not least, on my first migration attemps I don't get events on my object , looking into it before a complete switch :)

ok 😉

btw: which Deebot model are you using?

from ecovacs-deebot.js.

nicoduj avatar nicoduj commented on September 23, 2024

I am working on the pull request, will submit my whole changes once I have something working. I use a deebot ozmo slim 10. IT is a code matter, since if i set the event in my api class, i get it , but when i retrieve vacbots objects through an array and set it on "top level", I d'ont. I think it is some changes from the new Vacbot() from original impl and your getVacBot function.

from ecovacs-deebot.js.

mrbungle64 avatar mrbungle64 commented on September 23, 2024

@nicoduj

Is the Deebot Ozmo Slim 10 model using MQTT or XMPP as communication protocol?

from ecovacs-deebot.js.

nicoduj avatar nicoduj commented on September 23, 2024

MQTT

from ecovacs-deebot.js.

boriswerner avatar boriswerner commented on September 23, 2024

Great :-)

from ecovacs-deebot.js.

nicoduj avatar nicoduj commented on September 23, 2024

Can you tell me when you will publish on NPM ? i have bumped the verison in package.json. I will then be able to make my plugin depends on your package instead of my fork, it will prevent some installations errors ;p

from ecovacs-deebot.js.

mrbungle64 avatar mrbungle64 commented on September 23, 2024

Can you tell me when you will publish on NPM ? i have bumped the verison in package.json. I will then be able to make my plugin depends on your package instead of my fork, it will prevent some installations errors ;p

I'm planning to publish it within the next hour. ok?

from ecovacs-deebot.js.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.