Currently the panning stops once you lift your finger. For the panning to feel more natural, it would be great if there was an optional fling gesture support.

Found this example code on developer.android.com while searching around for a solution. But needs to be implemented in a pointerInput scope, so I think it has to be implemented inside the library.

Hi,

thank you for awesome library! I found nothing else as sophisticated as your Zoomables, great job!

As I am in the process of implementing an image-gallery, I would like to disable content-rotation.

So it would be nice to have a booelan-flag to enable/disable rotation for the Zoomable-composable-function.
The boolean-parameter lockRotationOnZoomPan would then only take effect if rotation is enabled.

Would you be open to implement such a feature or alternatively for a Merge Request for me to add this?

Hi, I think what you create is very good. Thanks a lot

To other that needed some sample how to use it, here it is :

val scope = rememberCoroutineScope()
val zoomableState = rememberZoomableState()

...
ZoomableImage(
		modifier = Modifier
			.fillMaxWidth()
			.fillMaxHeight(0.95f),
		coroutineScope = scope, zoomableState = zoomableState,		
	)	

Hi,

I would propose a little behavior optimization in that the Zoomable should zoom in on the last touchpoint when using the double-tap zoom feature (which is awesome, by the way).

Would that be possible to implement?

The bug happens when you are pinch zooming and dragging, and lift one finger and try to continue dragging. The drag does not work. Although, I can't seem to reproduce all the time, but it happens often. I have attached a video of the issue. Happens at the very start and very end of the video.

As the title says, single touch panning does not call the onTransformation function of rememberZoomableState. It is triggered for multi-touch. Just to add, dragGestureMode was set to { DragGestureMode.PAN }.

Was trying to debug the issue, I think this line is the cause:

It would be great if you can also add the following to ZoomableImage:

1. An onTap callback. If I add my own pointerInput to the modifier to detect single taps, it breaks the double tap zoom.
2. Currently the default double tap only zooms it to 2f scale. Allow us to change this value. I know I could just copy the double tap implementation and give my own value, but I think it would be better if the double tap zoom value is configurable.
3. Also, allow changing the double tap AnimationSpec. This way we can give our own animation easing, duration etc.

Hi,

thanks again you for your library!

As I understand the parameters minimumSwipeDistance and onSwipeLeft / onSwipeRight, those parameters are designed to handle something like a Pager-like scenario in the unzoomed state, right?

In my app, I already tested your Zoomable in the context of the HorizontalPager-composable from the accompanist-library "com.google.accompanist:accompanist-pager:0.23.1", so my use-case is a bit different, as page-swiping is already handled by HorizontalPager.

The problem for me with the usage of Zoomable in HorizontalPager is the gesture-conflict happening in the zoomed state.
Depending on how slow or fast I do the drag-gesture, either Zoomable is panning the viewport to the zoomed content or HorizontalPager picks up the gesture and starts to swipe to the next page, which is not what the app-user would expect.

For me, the best solution would be to disable page-swiping if the Zoomable is in the zoomed state.
Would that be something that could be handled by Zoomable on its own or would I need to adapt the HorizontalPager for that somehow in regards to gesture-propagation?

I found this issue for disabling swipe for HorizontalPager, but the parameter for that is only re-introduced in a newer version of accompanist than I am currently using (it also depends on the newer alpha-version of Jetpack Compose).
So I guess the alternative for me would be to migrate to the newer accompanist-version and handle this by bubbling-up the zoomableState and disable the HorizontalPager-swipe in the zoomed state myself.

What do you think?