Git Product home page Git Product logo

testpilot-contribute's Introduction

testpilot-contribute

A minisite aggregating open bugs suitable for first-time contributors across Test Pilot's various projects and repositories.

Screenshot

Developing the site

To set up:

git clone https://github.com/chuckharmston/testpilot-contribute.git
cd testpilot-contribute
yarn install

Then to run the development server:

npm run start

To run the Storybook server simultaneously:

npm run storybook

To view the current Storybook: https://chuckharmston.github.io/testpilot-contribute.

To update the deployed Storybook:

npm run deploy-storybook

testpilot-contribute's People

Contributors

chuckharmston avatar vladikoff avatar

Watchers

 avatar  avatar  avatar  avatar

testpilot-contribute's Issues

Sort projects and skills in alphabetical order

Re: https://github.com/chuckharmston/testpilot-contribute/blob/f6106ab8cb1cd611b93d060c95b4fe606310a4e0/src/config.json#L67-L77

In the /src/config.json we have an array of repos [Test Pilot, Snooze Tabs, Containers, Screenshots, Activity Stream, Min Vid, Notes, Voice Fill, and Send], but on the site, the projects are sorted by [Send, Test Pilot, Screenshots, Min Vid, Containers].

They seem to be sorted consistently, so maybe they're being sorted by each repo's last updated date.

Update skill card styles.

In normal status, text should be align center, and no overlay. Icon size and card size need fine tune as well.

Use XMLHttpRequest instead of fetch.

Firefox appears to believe that a fetch request with a preflight that returns 204 is an error and fails with a NetworkError. This bug should:

  • Refactor to use XHR instead of fetch.
  • Reduce to a simple test case and file a bug on Bugzilla about this.

Add ability to filter results using query param

Currently https://contribute.testpilot.firefox.com/tasks seems to be a never-changing URL. It'd be nice if we could use query params to preselect projects and skills.

This'd let me add a link to https://testpilot.firefox.com/experiments/snooze-tabs which says "Good First Bugs" which goes to https://contribute.testpilot.firefox.com/tasks?project=snooze-tabs
Or something like https://contribute.testpilot.firefox.com/tasks?project=snooze-tabs&skill=HTML

403s from GitHub API due to too many requests

If you can refresh the site quick enough in a minute(?), it seems like you exhaust GitHub API requests, and the API endpoint returns a 403 and the site doesn't load fully and you're stuck w/ an indeterminate progress bar thing:

firefox_test_pilot_-_contribute

Not sure if we need to generate a GitHub token and give it to OPs, or pass along to Heroku, or whatever.

Conversely, instead of expensive queries to GitHub, maybe have some server endpoint which caches the results for 60 seconds locally. That way every page load wouldn't be hitting GitHub directly.

Update card sizes, colors

Card size, color (should be flat and photon color), icon size are incorrect
image


@ChenMorpheus WRT Issue 1: I'd greatly prefer that the card colors match those on the site for the the time being in order to maintain continuity.
In the case of Screenshots, we have a new icon that matches neither the one found in the design spec nor the one used on Page Shot:
https://github.com/mozilla-services/screenshots/blob/master/static/img/landing-icon-screenshots.svg


@johngruen For issue 1, that makes perfect sense. We were just worried that the style doesn't match the rest of Photon design.
As for screenshots icon, sorry that we grabbed the old icon. The one you mentioned is the correct icon. Nice catch!


From mozilla/testpilot#2767

Move repo to Mozilla org?

I'm fine leaving it under Chuck's account, but not sure if we wanted to keep all these safely behind the iron grip of Mozilla's GitHub org.

Allow filters to be used in concert.

Currently, setting one filter unsets the other. We should be smarter about this, allowing both filters to be used in concert and restricting the values of the other to prevent 0-result filter combinations.

Great Job, permission to use.

I would like to use this as a framework for Pi Reels Contributing App. Please, let me know if their are any problems with that. The Pi Reel project recently took part in Mozilla Sprint and hopes it will be accepted to the Moz Fest this year too.

Regards,
Steve

Uncaught TypeError: Cannot read property 'filter' of undefined

Steps to reproduce:

  1. In Google Chrome, go to https://contribute.testpilot.firefox.com/tasks/ (Oddly, I cannot repro in Firefox, but I think there is a different error there)

Actual results:

firefox_test_pilot_-_contribute

https://github.com/chuckharmston/testpilot-contribute/blob/a551171253fad0d2eaea397dddca1bc336ab12a4/src/selectors/filters.js#L13

import { createSelector } from 'reselect';

const taskSelector = state => state.tasks.data;
const filterSelectors = state => ({
  repo: state.filters.repo,
  skill: state.filters.skill
});

export default createSelector(
  taskSelector,
  filterSelectors,
  (tasks, filters) => {
    return tasks.filter(task => {
      return (
        (filters.repo === null || task.repo.repo === filters.repo) &&
        (filters.skill === null ||
          task.skills.some(skill => filters.skill === skill.tag))
      );
    });
  }
);

// WEBPACK FOOTER //
// ./src/selectors/filters.js

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.