In the posts list, the "Edit Post" button is placed under the post content in <article>.

But when you display the post standalone, the button is in <header> and overflowed by <address> and <p class="entry-comments">.

IMO placing the button there is OK, but should be better positioned and also definitely fully visible. Moving the button into the <header> in the list might be considered too.

The issue is hidden here https://github.com/mozilla/One-Mozilla-blog/blob/master/themes/OneMozilla/functions.php#L462 - the "_fc_featuredpost" post meta is updated only if $_POST["_fc_featuredpost"] is set = only if the "_fc_featuredpost" input was successful and checked. Am I right?

If so, this seems to have a pretty simple fix, but I would like to do some testing before. Possible use case I am afraid of:

• mark post as featured
• save the post
• log in as another user (who does not have the featured widget switched on for editing posts)
• edit the post
• save the post
• is the previous "_fc_featuredpost" value send with the post edit form, or not?

I tried to fix it but couldn’t
line 50 on funtions.php :( using this:

add_theme_support( 'custom-header', array(
  // Header image default
  'default-image'     => get_template_directory_uri() . '/img/headers/firefox.png',
  // Header text display default
  'header-text'     => false,
  // Header image width (in pixels)
  'width'       => 340,
  // Header image height (in pixels)
  'height'      => 240
) );

http://make.wordpress.org/themes/2012/04/06/updating-custom-backgrounds-and-custom-headers-for-wordpress-3-4/

Sorry me, but if I'm not wrong it isn't possible to release a WordPress theme under licenses that are less strict than the GNU GPL, like the MPL 2.0.
https://wordpress.org/about/license/

Drupal's FAQs, that are more clear, can be used as similar guidelines:
https://www.drupal.org/about/licensing#q7

I think that the proper license can be choosed from one of:

• GNU GPL v2(+), v3(+)
• GNU AGPL v3(+)

https://www.gnu.org/licenses/license-list.html#MPL-2.0

On a smart phone (width 767px and lower) the menu is vertical and takes quite a lot of space, so no content below is visible without "scrolling". Thus when you click on a link in the menu, the visitor will see almost no response - the appropriate page is loaded, but still sees only the menu.

The current page could be somehow highlighted in the menu, or (better) hamburger menu should be for the mobile responsive version.

Maybe some menu re-composition could include also #8.

On the left from the Tabzilla tab, like on https://www.mozilla.org/, http://mozfr.org/ or http://www.mozilla.si/.

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please reach out to [email protected].

(Message COC001)

The Older posts link should be on the right, not on the left. At least for me it's pretty unusual to have it on the left, as I read from top to bottom and left to right, so I expect the older articles will be on the bottom or on the right.

Hello. Thanks for the great work. I'm having hard time displaying the sub-menu themes on the site after adding them. Please help. Thanks.

I hope One-Mozilla-blog themes should be also mentioned on Webdev/GetInvolved/WordPress wiki page, as it's linked e.g. from WhatCanIDoForMozilla.org. Or other related pages, so the communities can find it easily.

Currently Tweet button will always use "via @Firefox". This should be configurable in the settings to allow mentioning @firefoxnightly or @MozillaCZ in our case.

@kyoshino would you be interested?

Description

The "Technology" link in the navigation of the Mozilla Blog leads to an unmaintained site.

Steps to reproduce

Expected result

Link should lead to a maintained site.

Actual result

Link leads to an unmaintained site

Environment

Link does not depend on OS/platform/browser.

Proposed resolution

Link 'Technology" to https://mozilla.dev/, which is maintained (and has a hard launch August 26).
As discussed with MJ Kelly and Justin Crawford via email on 27 July 2020.

Line 28 in header.php causes 404 in our Mozilla.cz child theme (and possibly also in other One-Mozilla-blog child themes).

Instead of bloginfo('stylesheet_directory') I suggest to use get_template_directory_uri() (as in functions.php or comments.php). Of course this can be fixed in the child themes separately, but other .js files treated differently ok.

Since Mozilla updated the brand assets, there are still parts of the blog that don't match the new brand (for example the logo at the bottom).

I've installed the theme on Hebrew WordPress. While most of the strings appear to be localized, I've found some hardcoded strings (for example here: https://github.com/mozilla/One-Mozilla-blog/blob/master/themes/OneMozilla/comments.php#L26), and other places that require us to set a gettext domain named onemozilla, while these strings could be fetched from the default branch (so we won't need to translate it at all if the core WordPress is already localized).

Filing an issue to nag myself to work on this. https://bugzilla.mozilla.org/show_bug.cgi?id=1093562

It will require adding another option field for twitter account and passing that value into the share widget where it's embedded (with a data attribute).

Hi. I was unable to find 'One response'/'%d responses' string in the l10n files (onemozilla.pot
). Maybe other strings could be missing, but haven't noticed so far.

The string is here: https://github.com/mozilla/One-Mozilla-blog/blob/master/themes/OneMozilla/comments.php#L29

As we plan to use OneMozilla theme on our community site, there is something that I wish to change that might interest others. Instead of disabling comments, I wish to disable comments to people who are not logged in to WordPress, which includes search engines and casual visitors while people who have account on the site includes authors as well as active contributors who can suggest changes on the comments.

In case this request would be accepted, we need to add a theme option on functions.php and a condition such as if (not comments_allowed_to_guests and user_logged_in) then show_comments on comments.php.

I think there should be an option for enabling share buttons for posts only (or pages only).

Using this function should be more secure, as now we depend on site_url, which is not great e.g. when you visit a site over HTTPS, when HTTP url is set in the WordPress preferences.

According to http://ogp.me/#array, there can be more og:image for one document. I think, there may be listed all images attached to the post. Listing them is possible using get_attached_media().

Any plans of updating the theme to go with the latest Mozilla style or brand identity [https://mozilla.design/]?

I am co-writing a blog post for https://blog.mozilla.org/security/ that is supposed to go out late next week. Can co-author support be added to that blog? Thanks!

https://mozilla.ninja/typography specifies the more readable Fira Sans for body text. Please switch to that.
(And to Zilla for headlines, once it becomes available.)

Please do not ignore prefers-color-scheme.