mozilla / makeapi-client Goto Github PK

View Code? Open in Web Editor NEW

5.0 5.0 12.0 654 KB

INACTIVE - http://mzl.la/ghe-archive - Make API Client Library

License: Mozilla Public License 2.0

JavaScript 100.00%

inactive unmaintained

makeapi-client's People

Contributors

Stargazers

Watchers

Forkers

alicoding cadecairos jbuck k88hudson jdotpz toolness sedge peeyush81 ashwin02 mozilla-github-standards

makeapi-client's Issues

CODE_OF_CONDUCT.md file missing

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please reach out to [email protected].

(Message COC001)

add methods for tagging and un-tagging

see mozilla/MakeAPI#234

Documentation for create() is out of sync w/ staging

I tried using create() as it's currently documented and got this:

{
  "status": "failure",
  "reason": {
    "message": "Validation failed",
    "name": "ValidationError",
    "errors": {
      "email": {
        "message": "Validator \"required\" failed for path email",
        "name": "ValidatorError",
        "path": "email",
        "type": "required"
      }
    }
  }
}

I then renamed the maker option to email and got this:

{
  "status": "failure",
  "reason": {
    "message": "Validation failed",
    "name": "ValidationError",
    "errors": {
      "title": {
        "message": "Validator \"required\" failed for path title",
        "name": "ValidatorError",
        "path": "title",
        "type": "required"
      },
      "contentType": {
        "message": "Validator \"required\" failed for path contentType",
        "name": "ValidatorError",
        "path": "contentType",
        "type": "required"
      },
      "url": {
        "message": "Validator \"required\" failed for path url",
        "name": "ValidatorError",
        "path": "url",
        "type": "required"
      }
    }
  }
}

Then I moved everything in the make option up a level, alongside email, and the call succeeded.

Infinite recursion on make.update()

It looks like this bug was introduced in ec122d5... When calling update() on a make, node bails with an infinite recursion error. If I roll back to 0.5.17 on npm (I would roll back to 0.5.18, but it's not on npm), the error goes away.

Wiki changes

FYI: The following changes were made to this repository's wiki:

defacing spam has been removed
the wiki has been disabled, as it was not used

These were made as the result of a recent automated defacement of publically writeable wikis.

Info for some URLs cannot be obtained

So the following URL is an existing make:

https://jess.makes.org/thimble/MTY3NTY4OTk4NA==/mobile-design-ideation-kit

However, calling makeapi.url() with that URL:

var makeapi = new Make({apiURL: 'https://makeapi.webmaker.org'});

makeapi
  .url("https://jess.makes.org/thimble/MTY3NTY4OTk4NA==/mobile-design-ideation-kit")
  .then(function (err, makes) {
    if (err) throw err;
    console.log("# of makes: " + makes.length);
  });

causes the text # of makes: 0 to be logged to the console.

Any ideas?

InvalidStateError raised in IE10+

We're setting the timeout property of an XHR before we're calling open(), which makes IE mad. The following smoke test can reproduce the error:

<!DOCTYPE html>
<meta charset="utf-8">
<title>MakeAPI Client Smoke Test</title>
<pre id="status">Getting some makes...</pre>
<script src="src/make-api.js"></script>
<script>
var makeapi = new Make({apiURL: 'https://makeapi.webmaker.org'});
var status = document.getElementById('status');

makeapi.then(function (err, makes) {
  status.textContent = (err ? 'ERROR: ' + err
                            : 'Yay, got ' + makes.length + ' makes!');
});
</script>

Documentation for delete() should be remove()

There is no method called delete(); it's remove() in the current master.

Support sortByField: 'likes'

For http://weblitmapper.webmakerprototypes.org/, we'd like to make it possible to show the submitted resources by number of likes, so that we can surface the popular ones, but it doesn't seem like sortByField: 'likes' does anything. Can this be implemented?

Documentation for like() and unlike() should mention username, not email

The documentation for like() and unlike() mentions that a user's email address should be passed-in, but on staging this results in a 500. Using a username instead works.

mozilla / makeapi-client Goto Github PK

makeapi-client's People

Contributors

Stargazers

Watchers

Forkers

makeapi-client's Issues

CODE_OF_CONDUCT.md file missing

add methods for tagging and un-tagging

Documentation for create() is out of sync w/ staging

Infinite recursion on make.update()

Wiki changes

Info for some URLs cannot be obtained

InvalidStateError raised in IE10+

Documentation for delete() should be remove()

Support sortByField: 'likes'

Documentation for like() and unlike() should mention username, not email

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent