mozilla-releng / balrogscript Goto Github PK

We have tox.ini and setup.py and two requirements.txt files.

I'd like to see a minimal set of unpinned/minimally-pinned reqs in requirements-dev.txt, and use dephash to expand and pin them in requirements-prod.txt like the other *scripts. We can also reduce the tox.ini and setup.py deps to the minimal set of unpinned/minimally-pinned reqs.

19:25:27 I don't think it cares https://github.com/mozilla-releng/balrogscript/blob/master/balrogscript/script.py#L51 from a balrogscript perspective
19:25:48 that's a bug
19:26:09 we should prevent it from submitting to nightly / release channels on prod balrog if the scopes don't match
19:26:13 but we can test as is for now

Better late than never, reminder to add full-coverage.

Rename https://github.com/mozilla-releng/balrogscript/blob/master/balrogscript/balrogscript.py to https://github.com/mozilla-releng/balrogscript/blob/master/balrogscript/script.py to align with beetmover and signing scriptworkers.

Right now we have project:releng:balrog:server:* and project:releng:balrog:CHANNEL... which means if we want to make the channel scope mean something, we can't give star scopes, or we're giving server star scopes as well. We probably want to move this to project:releng:balrog:channel:CHANNEL

https://tools.taskcluster.net/task-inspector/#BxQjEj5VQUaNJndD7sBZ5Q/0

Manifest.json download failed. Investigate whether it's because the artifact https://tools.taskcluster.net/task-inspector/#1LXoSA31Qgmff5kLZj-V6w/ is inaccessible from age or permission.

As of January 1 2019, Mozilla requires that all GitHub projects include this CODE_OF_CONDUCT.md file in the project root. The file has two parts:

1. Required Text - All text under the headings Community Participation Guidelines and How to Report, are required, and should not be altered.
2. Optional Text - The Project Specific Etiquette heading provides a space to speak more specifically about ways people can work effectively and inclusively together. Some examples of those can be found on the Firefox Debugger project, and Common Voice. (The optional part is commented out in the raw template file, and will not be visible until you modify and uncomment that part.)

If you have any questions about this file, or Code of Conduct policies and procedures, please reach out to [email protected].

(Message COC001)

• Use Docker & Docker Compose for running a local dev environment, based on the python:3 image
• Use pip-compile-multi, and Pyup.io for dependency management
  • See https://github.com/mozilla-releng/releng-rfcs/blob/master/rfcs/0022-app-best-practices.md#dependency-management for requirements file details.
• Use tox as a test runner
• Use Taskcluster for CI
• Ensure production pushes happen manually, in response to bugs filed
• Ensure stage pushes happen in response to balrog_stage tags on Dockerhub
• Eliminate the development environment, if it exists

In the last beta, the balrog jobs runtime, cumulated was 0 days 05:13:55.830000 which represents ~2.03% in total to run, mostly because we spend a lot of time sleeping. Let's sleep less between retries.

It would be great to add Taskcluster CI support so we don't wait hours (it happened today) for travis.

This causes issues when trying to puppetize with all of balrogscript's requirements in the py2 venv -- we can't install towncrier.

Within the deployment in puppet, we actually clone this repo and deploy it. This is wrong, it should be pinned to some version. Easiest way would be to wrap all this up in a balrogscript python package and distribute that instead of cloning.

Again - not blocking but would be nice to have before Tier-1.

That may just be adding nightly-date (or whatever the date channel is called) to this line in puppet.

Offtopic, more related to http://scriptworker.readthedocs.io/en/latest/releases.html, Aki said we might hit issues in 3.5 environments generating and uploading to pypi because async does not work with setup.py for some reason. That might be fixed in the meantime as I managed to do it for beeetmoverscript.

https://github.com/mozilla-releng/balrogscript/network/alerts

Since we're no longer using the S3 uploading code, we might as well ditch it.

Since we don't yet use this in production, but we're about to, I thought it'd be a good idea to rename this to balrogscript to be more intuitive. It's not blocking Tier-2 but would be nice before Tier-1.

Use python3 instead of python2.
async and other refactoring are out-of-scope (unless they block py3-ification).
Blocks #7