moxystudio / eslint-config Goto Github PK

View Code? Open in Web Editor NEW

13.0 13.0 5.0 3.46 MB

MOXY eslint configuration to be used across several JavaScript projects

License: MIT License

JavaScript 86.40% Vue 13.52% TypeScript 0.08%

coding-standards coding-style eslint eslint-config javascript

eslint-config's People

Contributors

Stargazers

Watchers

Forkers

afonsovreis adao99 zebateira isabella232

eslint-config's Issues

An in-range update of eslint is breaking the build 🚨

Version 4.5.0 of eslint just got published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.4.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

v4.5.0

decdd2c Update: allow arbitrary nodes to be ignored in indent (fixes #8594) (#9105) (Teddy Katz)
79062f3 Update: fix indentation of multiline new.target expressions (#9116) (Teddy Katz)
d00e24f Upgrade: chalk to 2.x release (#9115) (Stephen Edgar)
6ef734a Docs: add missing word in processor documentation (#9106) (Teddy Katz)
a4f53ba Fix: Include files with no messages in junit results (#9093) (#9094) (Sean DuBois)
1d6a9c0 Chore: enable eslint-plugin/test-case-shorthand-strings (#9067) (薛定谔的猫)
f8add8f Fix: don't autofix with linter.verifyAndFix when fix: false is used (#9098) (Teddy Katz)
77bcee4 Docs: update instructions for adding TSC members (#9086) (Teddy Katz)
bd09cd5 Update: avoid requiring NaN spaces of indentation (fixes #9083) (#9085) (Teddy Katz)
c93a853 Chore: Remove extra space in blogpost template (#9088) (Kai Cataldo)

Commits

The new version differs by 12 commits.

ff8c4bb 4.5.0
480bbee Build: changelog update for 4.5.0
decdd2c Update: allow arbitrary nodes to be ignored in indent (fixes #8594) (#9105)
79062f3 Update: fix indentation of multiline new.target expressions (#9116)
d00e24f Upgrade: chalk to 2.x release (#9115)
6ef734a Docs: add missing word in processor documentation (#9106)
a4f53ba Fix: Include files with no messages in junit results (#9093) (#9094)
1d6a9c0 Chore: enable eslint-plugin/test-case-shorthand-strings (#9067)
f8add8f Fix: don't autofix with linter.verifyAndFix when fix: false is used (#9098)
77bcee4 Docs: update instructions for adding TSC members (#9086)
bd09cd5 Update: avoid requiring NaN spaces of indentation (fixes #9083) (#9085)
c93a853 Chore: Remove extra space in blogpost template (#9088)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Disable some react rules in tests

Disable the following rules in test files: react/jsx-no-bind, react/prop-types.

Thoughts?

Consider using `eslint-plugin-testing-library` and `eslint-plugin-jest-dom`

Found about these when I was first reading the following blog post by Kent Dodds: https://kentcdodds.com/blog/common-mistakes-with-react-testing-library.

Repositories:

Minor rule changes that are breaking changes

Disable ignoreEOLComments in no-multi-spaces so that spaces on comments are consistent
Specify no-restricted-properties:

{
    property: '__defineGetter__',
    message: 'Please use Object.defineProperty instead.',
},
{
    property: '__defineSetter__',
    message: 'Please use Object.defineProperty instead.',
}

Both are breaking changes.

Experiment and add eslint-plugin-prefer-import

See https://github.com/dferrazm/eslint-plugin-prefer-import

It would be cool to use this to enforce the use of import when the es6-modules addon is activated.
This should be a warning instead of an error because there are still cases when we must use require, e.g.: conditional loading.

An in-range update of eslint is breaking the build 🚨

The devDependency eslint was updated from `5.12.0` to `5.12.1`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v5.12.1

eb5c401 Chore: use meta.messages in some rules (2/4) (refs #9870) (#10773) (薛定谔的猫)
aa56247 Fix: avoid loading core rules dynamically from FS in Linter (#11278) (Peter Metz)
04450bb Docs: clarify process for adding committers (#11272) (Kai Cataldo)
3ffcf26 Docs: add @g-plane as committer (#11277) (Kai Cataldo)
c403445 Fix: warn constant on RHS of || in no-constant-condition (fixes #11181) (#11253) (Merlin Mason)
9194f45 Fix: Manage severity of 1 with TAP reporter (fixes #11110) (#11221) (Gabriel Cousin)
000f495 Docs: fix example for sort-imports ignoreDeclarationSort (#11242) (Remco Haszing)
7c0bf2c Docs: Add npx usage to Getting Started guide (#11249) (eyal0803)
da9174e Docs: fixes typo peerDepencies (#11252) (Christian Kühl)
9c31625 Docs: Improve custom formatter docs (#11258) (Nicholas C. Zakas)

Commits

The new version differs by 12 commits.

faf3c4e 5.12.1
1010c98 Build: changelog update for 5.12.1
eb5c401 Chore: use meta.messages in some rules (2/4) (refs #9870) (#10773)
aa56247 Fix: avoid loading core rules dynamically from FS in Linter (#11278)
04450bb Docs: clarify process for adding committers (#11272)
3ffcf26 Docs: add @g-plane as committer (#11277)
c403445 Fix: warn constant on RHS of || in no-constant-condition (fixes #11181) (#11253)
9194f45 Fix: Manage severity of 1 with TAP reporter (fixes #11110) (#11221)
000f495 Docs: fix example for sort-imports ignoreDeclarationSort (#11242)
7c0bf2c Docs: Add npx usage to Getting Started guide (#11249)
da9174e Docs: fixes typo peerDepencies (#11252)
9c31625 Docs: Improve custom formatter docs (#11258)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Improve capitalized-comments to allow commenting code

Basically it would be cool if we could comment out code without capitalized-comments erroring out.

This would require us to ignore language statements, such as import, function, var, let, const, etc

An in-range update of eslint-plugin-jsdoc is breaking the build 🚨

The dependency eslint-plugin-jsdoc was updated from `3.8.0` to `3.9.0`.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-jsdoc is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details

❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Release Notes for v3.9.0

3.9.0 (2018-10-19)

Bug Fixes

@ private skip require checks (#86) (767a788)
correct auto release (fixes #97) (175ef6d)
correct README generation logic (38e30f5)
revert @ private skip require checks (issue #78) (#89) (b132a6c), closes #88 #86
update dependencies (#81) (e496523)

Features

add require-description (#91) (1778446)
set line locations when reporting violations (#88) (95df73e)

Commits

The new version differs by 9 commits.

175ef6d fix: correct auto release (fixes #97)
38e30f5 fix: correct README generation logic
69acabd chore: automate git hooks
ca7e71f chore: update dependencies
1778446 feat: add require-description (#91)
b132a6c fix: revert @ private skip require checks (issue #78) (#89)
95df73e feat: set line locations when reporting violations (#88)
767a788 fix: @ private skip require checks (#86)
e496523 fix: update dependencies (#81)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.

Your Greenkeeper Bot 🌴

Remove rules no longer needed in React 17

When React 17 is released and we adopt it in our projects, the following rules will no longer be necessary:

react/jsx-uses-react
react/react-in-jsx-scope

Source: https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html#eslint

Add jsdoc validation

Update `eslint-plugin-jsx-a11y` to v6.3.1

It appears a few changes were introduced between v6.2.1 and v6.3.1 which are breaking our tests. Check the following links for more information:

Consider using eslint-plugin-babel

Currently we have problems with no-invalid-this on rwm. Basically we´re having a linting error using this on class properties, and we shouldn't.

eslint-plugin-babel re-implements problematic rules so they do not give false positives or negatives.

re-implementation of `no-invalid-this': https://github.com/babel/eslint-plugin-babel/pull/101/files

Do not allow arrow functions in react props

Interesting read: https://bytes.referralcandy.com/react-pure-components-now-with-more-weakmaps-f676ce8162e7#.5n6suhnqh

We should disallow arrow functions and perhaps activate class props declaration to easily bind functions to instances.

An in-range update of lint-staged is breaking the build 🚨

Version 4.2.0 of lint-staged just got published.

Branch	Build failing 🚨
Dependency	lint-staged
Current Version	4.1.3
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As lint-staged is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build could not complete due to an error Details

Release Notes

v4.2.0

4.2.0 (2017-09-15)

Features

Print friendlier error if config is missing (#281) (30fa594)

Commits

The new version differs by 8 commits.

30fa594 feat: Print friendlier error if config is missing (#281)
0077644 chore: Cleanup package.json (#250)
7abe23f ci: Disable email notifications from Travis CI
c9d0849 docs: Use emojis in the Readme
e976a3c docs: Add screenshot with the animated gif (#276)
92e586b docs: Reformat code blocks
9b0282a docs: Use diff formatting for code
33da9b3 ci: Whitelist build branches to avoid duplicate builds (#269)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Enforce lowercase in test names

Add the lowercase-name rule to our eslint-config-jest config. This rule makes it so test names have to be written in lowercase.

Support ESM for Node.js

ESM is already supported in Node.js since v12 [docs]. However, we're currently missing proper support and documentation as follows:

Top-level await triggers an error
.mjs files are not being considered for linting
There are no instructions on how to setup a config for ESM in Node.js
...anything else?

@satazor @threequartersjohn thoughts?

Remove commitHooks setting from Lerna's publish config

See: moxystudio/jest-config#24 (comment)

Re-evaluate our `indent` rule exceptions

Currently, our indentation is 4 spaces, with a few exceptions:

        'indent': [2, 4, {
            'SwitchCase': 0,
            'MemberExpression': 0,
        }],

Re-evaluate these exceptions to see if we can remove them. As an example, because we are forcing MemberExpression to 0, the following code becomes unreadable:

const schema = {
    headers: Joi.object({
        'Content-Type': Joi
        .string()
        .pattern(/^application\/json\b/)
        .required(),
    }),
};

which would be much more readable like so:

const schema = {
    headers: Joi.object({
        'Content-Type': Joi
            .string()
            .pattern(/^application\/json\b/)
            .required(),
    }),
};

To circumvent the above issue, I would have to write it like so:

const schema = {
    headers: Joi.object({
        'Content-Type':
            Joi
            .string()
            .pattern(/^application\/json\b/)
            .required(),
    }),
};

Reminder: after update to ESLint v6, dissalow 'allow require for configs' for nested configs

When this package updates to version 6 of ESLint, we must update our override for .config.js files to disallow that same override for nested .config.js files.

This override can be found here.

The update is probably going to be something like:

'files': './*.config.js'

An in-range update of eslint is breaking the build 🚨

Version 4.7.2 of eslint just got published.

Branch	Build failing 🚨
Dependency	eslint
Current Version	4.7.1
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

As eslint is “only” a devDependency of this project it might not break production or downstream projects, but “only” your build or test tools – preventing new deploys or publishes.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

v4.7.2

4f87732 Fix: Revert setting node.parent early (fixes #9331) (#9336) (Teddy Katz)

Commits

The new version differs by 3 commits.

e164397 4.7.2
b7818ba Build: changelog update for 4.7.2
4f87732 Fix: Revert setting node.parent early (fixes #9331) (#9336)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Jest addon should only work inside test/

See: https://github.com/reactjs/redux/blob/de94043033fdd13dc4fa3cede2943143c6d28942/.eslintrc.js#L4

An in-range update of lint-staged is breaking the build 🚨

Version 4.0.4 of lint-staged just got published.

Branch	Build failing 🚨
Dependency	lint-staged
Current Version	4.0.3
Type	devDependency

This version is covered by your current version range and after updating it in your project the build failed.

I recommend you give this issue a high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

v4.0.4

4.0.4 (2017-08-24)

Bug Fixes

Disable concurrent sub task execution by default (#229) (48c8c6ff, closes #225)

Commits

The new version differs by 2 commits.

48c8c6f fix: Disable concurrent sub task execution by default (#229)
2eb10a4 chore: Disallow lockfiles (#224)

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Add tests

Consider enabling linting of markdown files

So that code blocks are validated.

See: https://www.npmjs.com/package/eslint-plugin-markdown

Prefer object spread instead of Object.assign

Now that node 8.9 has object spread, we can activate https://www.npmjs.com/package/eslint-plugin-prefer-object-spread.

jest global throws 'not defined' error in global mock

When defining a global mock in __mocks__/<filename>.js, using the jest global causes the linter to throw a jest is not defined error.

We should modify the @moxy/eslint-config-jest package to also override the ESlint config for the files in this directory.

Revisit some rules regarding react

Allow more than one component per file
Allow stateless components
Allow arrow functions in props
Remove _ prefix in private methods (syntax for private methods will be #, see proposal)

/cc @andregoncalvesdev

We should probably align this with #15 in a major release.

Specify react version

At the moment, https://github.com/yannickcr/eslint-plugin-react is issuing a warning because we are not specifying a react version. We should default it to the latest react and perhaps document how to override it.

An in-range update of eslint-plugin-react is breaking the build 🚨

Version 7.2.0 of eslint-plugin-react just got published.

Branch	Build failing 🚨
Dependency	eslint-plugin-react
Current Version	7.1.0
Type	dependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-react is a direct dependency of this project this is very likely breaking your project right now. If other packages depend on you it’s very likely also breaking them.
I recommend you give this issue a very high priority. I’m sure you can resolve this 💪

Status Details

❌ continuous-integration/travis-ci/push The Travis CI build failed Details

Release Notes

v7.2.0

Added

Add no-unused-state rule (#1103 @wbinnssmith)
Add boolean-prop-naming rule (#1264 @EvHaus)
Add no-typos rule (#1189 @jseminck, #1294 @haridusenadeera)
Add auto fix for sort-props (#1273 @Overload119)
Add getters and setters groups to sort-comp (#100 @RDGthree)
Add noStrings option to no-literals (#1202 @deecewan)
Add inverse option for always/never to jsx-boolean-value (#1249 @ljharb)

Fixed

Fix no-direct-mutation-state to disallow this.state mutation in constructor (#832 @burabure)
Fix jsx-no-target-blank crash on empty rel attribute (#1269 @dustinsoftware)
Fix sort-comp component detection with ClassExpression (#1076 @webOS101)
Fix no-unused-prop-types detection with async class properties and methods (#1053 @benstepp)
Fix void-dom-elements-no-children crash (#1226 @kokobeware)
Fix no-danger-with-children to ignore line breaks (#1262)
Fix no-danger-with-children crash with undefined (#1287)
Fix jsx-no-target-blank crash (#1296 @jseminck)
Fix no-unused-props to no longer ignore components with no used props (#1303 @DianaSuvorova)
Fix jsx-no-duplicate-props crash (#969 @marcelmokos)
Fix no-literals false positives (#1301 @davidyorr)
Fix no-find-dom-node detection with named imports (#785 @Hypnosphi)
Fix proTypes-related rules detection with wrapped propTypes (#1266 @dustinsoftware)
Fix no-unused-prop-types detection with propTypes wrapped in a function (#1253 @dustinsoftware)
Fix no-unused-prop-types detection with destructured use of properties (#816 @DianaSuvorova)
Fix no-unused-prop-types detection with inline functions (#1309 @DianaSuvorova)
Fix no-unused-prop-types skipShapeProps option with Flow annotations (#1335 @DianaSuvorova)
Fix jsx-curly-spacing schema incompatibility with ESLint 4.2.0 (#1290 @jseminck)

Changed

Documentation improvements (#1261 @mminer, #1005 @yooungt13, #1289 @konekoya, #1308 @xcatliu, #1306 @egberts, #1329 #1344 @DianaSuvorova)
ES6-ify codebase (#1274 #1277 #1281 @dfilipidisz)
Code refactoring (@ljharb)
Update Travis CI and AppVeyor CI configurations (@lencioni)

Commits

The new version differs by 153 commits.

73abadb Update CHANGELOG and bump version
1a622ea Merge pull request #1343 from DianaSuvorova/unusedPropsFlow
f9c22ef Merge pull request #1273 from Overload119/master
d66808b Modernize to use let and const
e305279 Merge pull request #1344 from DianaSuvorova/docs
15d0f74 [no-unused-prop-types] test from #933
f446335 [no-unused-prop-types] known false positives doc
95acd93 Merge pull request #1341 from DianaSuvorova/flowShape
942e594 flow should respect skipShapeProps
f0487f2 Merge pull request #1338 from DianaSuvorova/graphql
b6bd2da [no-unused-prop-types] graphql issue #1097
df84876 Update dependencies
a19eec6 Merge pull request #1294 from haridusenadeera/master
ed72341 Merge pull request #1329 from DianaSuvorova/docs
3195805 Merge pull request #1302 from davidyorr/master

There are 153 commits in total.

See the full diff

Not sure how things should work exactly?

There is a collection of frequently asked questions and of course you may always ask my humans.

Your Greenkeeper Bot 🌴

Add Node CI with GitHub Actions

Consider laxing `max-len`

Currently, I can't have a multiline template string that contains a paragraph that has more than 140chars:

        str += `
It's a bad practice having files being output with hashes during development. Your output folder will become filled with a lot of different files after a few rebuilds.

Additionally, this is know to cause ${chalk.bold('memory leaks')} with ${chalk.bold('webpack-dev-middleware\'s')} in-memory filesystem.
Either ${chalk.bold('avoid having hashes')} in development or disable in-memory filesystem through the \`memoryFs\` option.

If you feel this was a false positive, please ignore this warning.

`;

We should consider laxing this rules in a few cases, see https://eslint.org/docs/rules/max-len

moxystudio / eslint-config Goto Github PK

eslint-config's People

Contributors

Stargazers

Watchers

Forkers

eslint-config's Issues

Version 4.5.0 of eslint just got published.

The devDependency eslint was updated from 5.12.0 to 5.12.1.

The dependency eslint-plugin-jsdoc was updated from 3.8.0 to 3.9.0.

3.9.0 (2018-10-19)

Bug Fixes

Features

Version 4.2.0 of lint-staged just got published.

4.2.0 (2017-09-15)

Features

Version 4.7.2 of eslint just got published.

Version 4.0.4 of lint-staged just got published.

4.0.4 (2017-08-24)

Bug Fixes

Version 7.2.0 of eslint-plugin-react just got published.

Added

Fixed

Changed

Recommend Projects

Recommend Topics

Recommend Org

The devDependency eslint was updated from `5.12.0` to `5.12.1`.

The dependency eslint-plugin-jsdoc was updated from `3.8.0` to `3.9.0`.