Comments (2)
Yeah, I've been aware of that for a while but, probably out of laziness, I never fixed it.
I think that, while downloading a subtitles file, we should always validate if it's HI or not. The file should be named accordingly, not using the language known by the provider. guess_external_subtitles should then return the same value on each execution. Make sense?
from bazarr.
It looks like the subtitle is saved to file based on what the provider thinks the language is. If it thinks it's English but not hearing impaired it'll get saved as *.en.srt
for example
After that, guess_external_subtitles
is called which reads the file and finds it to be hearing impaired. It is then saved to the database as being hearing impaired.
On re-scan, the language of an external subtitle is initially set based on its filename, which in this case is English non-hearing impaired as it's still just *.en.srt
.
When guess_external_subtitles
is called again, it does not read the file to change the language to hearing impaired because of the previously_indexed_subtitles_to_exclude
argument. This makes it forever treated as non-hearing impaired.
My questions here are:
- Should the provider be trusted and the file always treated as non-hearing impaired? Or should the file scan during
guess_external_subtitles
be consistent from then on and it always being treated as hearing impaired? - Should the result of
guess_external_subtitles
change the filename to match what it thinks it is?
from bazarr.
Related Issues (20)
- cant download subtitles HOT 3
- Exception on /api/movies [PATCH] (docker, Ubuntu) HOT 4
- BAZARR mediainfo cannot analyze this video file HOT 11
- Homebrew formula broken: Internal Server Error HOT 6
- Subdivx provider not working in 1.4.2-beta.6 HOT 7
- Problem with PT-PT subtitles HOT 1
- Edit tools change ASS subtitle's content to SRT format without change file extension. HOT 3
- Subtitle's content is messed up while watching in Jellyfin and uploading new file. HOT 4
- Bazarr doesn't run after a reboot HOT 9
- Subdivx provider raises JSONDecodeError when searching for subtitles HOT 2
- Problem with yifysubtitles links HOT 1
- Blank white page after login HOT 1
- Sync settings changes aren't being applied without restarting Bazarr HOT 1
- Movies from Radarr that use Symlinks don't evaluate to the correct path HOT 4
- Legendasdivx does not work with users with a password starting with the digit 0 HOT 1
- UnboundLocalError: cannot access local variable \'i\' where it is not associated with a value HOT 3
- Bug(UI): Wanted tables is overflowed HOT 1
- Error when using embeddedsubtitles provider HOT 4
- Subdivx broken again, however nothing seems to have changed on their side HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bazarr.