Comments (7)
@morpheus65535 sorry didn't see your fix on time. Mine works differently, just avoids querying with titles that contain non-allowed characters (in allowed I include all European diacriticals too, and the German ß) - basically eliminating the Korean, Japanese, Russian, Chinese, Hindi, etc. that will break Subdivx.
I've merged your solution and mine ; because it might still happen that it'd return 500, but also it's better (and faster) to reduce queries (specially troublesome queries) to the provider. So my pull request is there.
from bazarr.
Should be fixed in upcoming beta.7. Can you confirm please?
from bazarr.
Sure. I'll test it in the next beta release.
Thank you.
from bazarr.
@avraham , as you can see in the logs it's HTTP error 500 - it's an internal server error, it comes from Subdivx and it's transient. I've just tried and seems to work fine.
Try again and let us know.
from bazarr.
I stand corrected. The matter is that there's an alternate title in Korean ; the request breaks Subdivx. If you try to search "플레이어스|" (that's the alternative title) in Subdivx's website UI, it hangs forever.
As it does not make sense to search non-latin character encodings in Subdivx, I'll try to add some code to detect and drop those alternate titles.
from bazarr.
@rmichelena my latest fix return [] on 500.
from bazarr.
Ok, done ; tested with "Isle of Dogs (2018)" which has alternative titles in a lot of languages. Works ok.
I've forked and created a pull request, hope it's done correctly, first time contributing to a project :)
from bazarr.
Related Issues (20)
- Betaseries treats not found as authentication error HOT 1
- Migrating SQLite to PosgreSQL failed due to table_shows.alternativeTitle not existing in PostgreSQL database. HOT 8
- Fix the version info HOT 1
- Cant reset auth after restoring from backup HOT 3
- Bug(UI): search input in Firefox android has weird behavior with whitespace (gboard only) HOT 4
- Bug(UI): manually uploading subtitles dialog with a long file name doesn't wrap or work break HOT 6
- Golden-Section Search is not working when configured at Subtitles Settings HOT 2
- API of some kind ? (for a GPTsubtrans adaptation) HOT 3
- Titlovi HOT 2
- Bazarr does not restart successfully upon applying update HOT 14
- TV Show episode search looking at wrong episode HOT 2
- Upgrade to Ubuntu 24 and Python 3.12.3 HOT 20
- Bug(subtitles provider): animetosho stopped other providers if there is no series_anidb_id attribute HOT 4
- Cutoff menu missing :forced HOT 2
- Doesn't launch if there's no internet access HOT 6
- Anime Tosho KeyError HOT 5
- Cannot unpack non-iterable NoneType HOT 1
- WebUI seems to randomly crash? HOT 33
- Whisper fails on some files, but works fine on others HOT 5
- cant' install bazarr HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bazarr.