Git Product home page Git Product logo

Comments (7)

rmichelena avatar rmichelena commented on June 24, 2024 1

@morpheus65535 sorry didn't see your fix on time. Mine works differently, just avoids querying with titles that contain non-allowed characters (in allowed I include all European diacriticals too, and the German ß) - basically eliminating the Korean, Japanese, Russian, Chinese, Hindi, etc. that will break Subdivx.

I've merged your solution and mine ; because it might still happen that it'd return 500, but also it's better (and faster) to reduce queries (specially troublesome queries) to the provider. So my pull request is there.

from bazarr.

morpheus65535 avatar morpheus65535 commented on June 24, 2024

Should be fixed in upcoming beta.7. Can you confirm please?

from bazarr.

avraham avatar avraham commented on June 24, 2024

Sure. I'll test it in the next beta release.
Thank you.

from bazarr.

rmichelena avatar rmichelena commented on June 24, 2024

@avraham , as you can see in the logs it's HTTP error 500 - it's an internal server error, it comes from Subdivx and it's transient. I've just tried and seems to work fine.
Try again and let us know.

from bazarr.

rmichelena avatar rmichelena commented on June 24, 2024

I stand corrected. The matter is that there's an alternate title in Korean ; the request breaks Subdivx. If you try to search "플레이어스|" (that's the alternative title) in Subdivx's website UI, it hangs forever.
As it does not make sense to search non-latin character encodings in Subdivx, I'll try to add some code to detect and drop those alternate titles.

from bazarr.

morpheus65535 avatar morpheus65535 commented on June 24, 2024

@rmichelena my latest fix return [] on 500.

from bazarr.

rmichelena avatar rmichelena commented on June 24, 2024

Ok, done ; tested with "Isle of Dogs (2018)" which has alternative titles in a lot of languages. Works ok.
I've forked and created a pull request, hope it's done correctly, first time contributing to a project :)

from bazarr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.