morpheums / binance.api.csharp.client Goto Github PK

When i am trying to run this project, I am getting this error for all 3 bold functions. Any help please ?

For this file: BinanceClient.cs

For this line of code:

var args = $"symbol={symbol.ToUpper()}&interval={interval.GetDescription()}"
+ (startTime.HasValue ? $"&startTime={startTime.Value.GetUnixTimeStamp()}" : "")
+ (endTime.HasValue ? $"&endTime={endTime.Value.GetUnixTimeStamp()}" : "")
+ $"&limit={limit}";

Severity Code Description Project File Line Suppression State
Error CS0121 The call is ambiguous between the following methods or properties: 'Binance.API.Csharp.Client.Utils.ExtensionMethods.GetDescription(System.Enum)' and 'Binance.API.Csharp.Client.Utils.ExtensionMethods.GetDescription(System.Enum)' Binance.API.Csharp.Client C:\app\Bin\Binance.API.Csharp.Client-master\Binance.API.Csharp.Client\BinanceClient.cs 174 Active

Hi,
Did you test if EndPoints.NewOrder is working?
As long as I am using EndPoints.NewOrderTest, i can make a new place order, but after switch back real new order endpoint "/api/v3/order" i am keep getting 400 error,

Detail error message: One or more errors occurred. (Response status code does not indicate success: 400 (Bad Request).)

Request looks like:
/api/v3/order?symbol=EOSETH&side=BUY&type=LIMIT&quantity=1&timeInForce=GTC&price=100&recvWindow=5000&timestamp=1515267623189&signature=DE632680056FFDD09DAD6CA87544C485865BE10526A2089F66581E1FDF34C084

I have tried using the api in console application. Everything worked fine. However, when I tried using any of the methods in winforms app, by calling the method on button.onclick, the form freezes and is unresponsive.
I am using my api and secret but of course I am not posting them here.

`using Binance.API.Csharp.Client;
using Binance.API.Csharp.Client.Models.Enums;
using System;
using System.Collections.Generic;
using System.ComponentModel;
using System.Data;
using System.Drawing;
using System.Linq;
using System.Text;
using System.Threading.Tasks;
using System.Windows.Forms;

namespace binappp
{
    public partial class Form1 : Form
    {
        public Form1()
        {
            InitializeComponent();
        }

        private void button1_Click(object sender, EventArgs e)
        {
            ApiClient apiClient = new ApiClient("api", "secret");
            BinanceClient binanceClient = new BinanceClient(apiClient);
            binanceClient.PostNewOrder("btciota", (decimal)1, (decimal)0.0000008, OrderSide.BUY, OrderType.MARKET);
        }
    }
}

`

Hi all,
I'm new to C# and I'm trying to understand how to use this library for my own purpose. I've managed to acquire pairs prices for several hours and I've wrote them to a file and other things.

I'm having problems with the following line:

accountInformation = await client.GetAccountInformation(3500);

My console application, let say a simplified version of the example in the package, crashes.

However seems that the connection works fine, and the line:

await client.TestConnectivity();

doesn't give any problems.

Any ideas?

What can I do for this compatibility issue?

Placing market orders was working fine until yesterday. I use the following standard command:

var sellMarketOrder = binanceClient.PostNewOrder("xxxbtc", 1000, 0, OrderSide.SELL, OrderType.MARKET).Result;

However, this has now suddenly stopped working and throwing an exception: "one or more errors occurred".

I wonder if Jose or anyone can throw any light as to why this wrapper has stopped functioning as expected. Other aspects of the API seem to be operational (var tickerPrices = binanceClient.GetAllPrices().Result), but market BUY and SELL have stopped.

I wonder if there's been any change on the Binance end, which maybe having an impact and this change has not been reflected in the wrapper.

Then again, if that was the case, I'd imagine we'd be seeing a lot more complaints here.

Hello Everyone,

I have am receiving a 400 "bad request" regardless what I do.
I can see that the code goes thru from my class all the way to ApiClient.cs and the request is being built correctly from what I can tell:

Did try the original www.binance.com same thing..
{https://api.binance.com/api/v3/account?recvWindow=5000&timestamp=1521743921941&signature=C9D3A45A7FD741308621F23753F13141BD5721C581EDEFBBDC0AE2D4979AACDA}

nonetheless I get a 400 error.

Can you please let me know what am I doing wrong?

This is the code I have used in my own class

    static string youtrapikey = "My key";  
    static string YourApiSecret = "My Secret";  

    private static ApiClient apiClient = new ApiClient(youtrapikey, YourApiSecret);
    private static BinanceClient binanceClient = new BinanceClient(apiClient, false);

    private void cmd_run_Click(object sender, EventArgs e)
    {       
           var accountInfo = binanceClient.GetAccountInfo().Result;
}

Thank you,

hi im trying to listen chartdata prices for specific pair with the function below but after some time later for example 1 day, new prices is not coming out. the function doenst give any exception or error it just stops working or maybe its still working but new prices is not coming anymore.(maybe server blocks my ip) do you know what may be the problem or do you have nay solution ? thank you. i wanna listen prices forever.

` private void KlineHandler(KlineMessage messageData)
{
var klineData = messageData;
}

public void TestKlineEndpoint()
{
    binanceClient.ListenKlineEndpoint("ethbtc", TimeInterval.Minutes_1, KlineHandler);
}

`

Hi!,

Is there a bug in the ammount of decimal places one can place in the price of a limit order?

If I put a price like the following it works fine (Price= 0.1):

But if I post a price like 0.01 it throws an error (error number 404).

Thanks!

I used the API for a while and it worked perfectly. I didn't change anything over night, but the next day I had this error:

Exception thrown: 'System.Exception' in System.Private.CoreLib.dll ("Api Error Code: -1021 Message: Timestamp for this request was 1000ms ahead of the server's time.") Exception thrown: 'System.Exception' in System.Private.CoreLib.dll ("Api Error Code: -1021 Message: Timestamp for this request was 1000ms ahead of the server's time.")

It looks like it's a problem within the API. Is anyone else having this too right now? Might Binance be offline or something like that?

I sent a request to get account info using the following code:

    public async Task<string> BalanceRequest(string apikey, string apisecret, string exchange)
    {

        var apiClient = new ApiClient(apikey, apisecret);
        var binanceClient = new BinanceClient(apiClient);
        var binance = await binanceClient.GetAccountInfo();   <-- line 29         
        return binance.Balances.Count().ToString();
    }

And i am getting exception:
Api Error Code: -1021 Message: Timestamp for this request was 1000ms ahead of the server's time.

i dont have much experince in c#, thank for your helping.

Is there any way to do Stop-Limit orders using this API (as I didn't see any), and if not, are there any plans for this to be added?

Need to validate an order before posting the order.
However, the trading rules json is not available as endpoint shared is returning 404.

Hello, I am starting with API. A simple question, but not for me :)
For the exemple:

var serverTime = binanceClient.GetServerTime().Result;

How I can see in console the result of this request?

Thank you.

Message: Filter failure: LOT_SIZE
what this message means?
i verified the minimum of that symbol to post the value.

I would like to use OCO orders.

I tried to implement but it didn't work.

If anyone succeeds it would be really cool.

public static readonly string TradingRules = "https://gist.githubusercontent.com/Ninj0r/3029b9d635f8f81f5ffab9cc9df5cc61/raw/810530a2118e5d8cdcfcc4d220349976a0acf131/tradingRules_20171022.json";

var apiClient = new ApiClient("API-Key", "API-Secret");
var binanceClient = new BinanceClient(apiClient); <------

I get the following error on the second line.

HttpRequestException: Response status code does not indicate success: 404 (Not Found).

Place Market order functionality always break out and throw an exception "at least 1 error occurred".
any help please

How to get the exchange info ? ie rate limit info?

Hello,

I followed all the instructions and reached the point to use the methods and it doesn't seem to return anything rather gets stuck at the method call statement. Can you please advice on what is missing?

Example: It is stuck here...
var candlestick = binanceClient.GetCandleSticks("ethbtc", TimeInterval.Minutes_15).Result;

They will steal your API Keys like they stole mine.

Hi to all
We installed this package.
After run code page go to loop.

    var apiClient = new ApiClient("qnQ1Y*****", "w7Fo******");
    var binanceClient = new BinanceClient(apiClient);
    var accountInfo = binanceClient.GetAccountInfo().Result;
    Response.Write(accountInfo.BuyerCommission);

No result no response.
Help please

Methods are simple to understand and use by themselves, but to stick them together might be a challenge for someone as shit at coding as I am. Would you mind providing simple one page file of console app, just calling most common methods, just to show the way how do cycle them without using some bullshit like 'while(true)'. Something like Marfusios'es example for his websocket connection to Bitfinex would be greatly appreciated.

Nice work! I've been able to connect end-to-end and am able to use this nicely written library.

However, I seem to be having issues with the ConnectToWebSocket() -- I don't get any messages events in

binanceClient.ListenDepthEndpoint("CNDETH", DepthMessageHandler);
and
binanceClient.ListenKlineEndpoint("CNDETH", Binance.API.Csharp.Client.Models.Enums.TimeInterval.Minutes_1, KlineHandler);

In ApiClient.cs, ConnectToWebSocket() method seems to call ws.Connect(); ok, but no messages are coming in -- seems to be just dead air. (OnError and OnClose callbacks are never fired)

As a test, I added an OnOpen() and it does get called when ws.Connect(); is executed in ApiClient.cs
ws.OnOpen+= (sender, e) => { Console.Write("Opened!"); };

Are the listener methods broken or am I not calling it correctly?
Below is my sample console app Main() code: Keys/Private not shown, just the body:

do
    {
      while (!Console.KeyAvailable)
        {
         if (!started)
           {
               Console.Write("listening...");
                 started = true;
                 //binanceClient.ListenDepthEndpoint("CNDETH", depthMessageHandler);
                 // binanceClient.ListenKlineEndpoint("CNDETH", Binance.API.Csharp.Client.Models.Enums.TimeInterval.Minutes_1, KlineHandler);
                    }
                    // Thread.Sleep(2000);
                }
            } while (Console.ReadKey(true).Key != ConsoleKey.Escape);

Handlers

private static void KlineHandler(KlineMessage messageData)
{
       Console.Write("Got KLINE Message!");
        Console.Write($"High: {messageData.KlineInfo.High} Low: {messageData.KlineInfo.Low}");
}

 private static void DepthMessageHandler(DepthMessage messageData)
  {
       Console.Write("Got Message!");
        if (messageData.UpdateId >= DepthMessages.UpdateId)
        {
           DepthMessages = messageData;
         }
        foreach(var m in DepthMessages.Bids)
         {
             Console.Write($"{m.Price}:{m.Quantity}");
         }
 }

Any suggestions?

This issue happened just 2 days ago, is this new problem from Binance API?

I'm getting this:

System.AggregateException was unhandled
  HResult=-2146233088
  Message=One or more errors occurred.
  Source=mscorlib
  StackTrace:
       at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
       at System.Threading.Tasks.Task`1.GetResultCore(Boolean waitCompletionNotification)
       at System.Threading.Tasks.Task`1.get_Result()
       at Binance.API.Csharp.Client.BinanceClient.LoadTradingRules()
       at Binance.API.Csharp.Client.BinanceClient..ctor(IApiClient apiClient, Boolean loadTradingRules)
       at ... .Program.StartUp() in c:\...\Program.cs:line 95
       at ... .Program.Main(String[] args) in c:\...\Program.cs:line 36
       at System.AppDomain._nExecuteAssembly(RuntimeAssembly assembly, String[] args)
       at System.AppDomain.ExecuteAssembly(String assemblyFile, Evidence assemblySecurity, String[] args)
       at Microsoft.VisualStudio.HostingProcess.HostProc.RunUsersAssembly()
       at System.Threading.ThreadHelper.ThreadStart_Context(Object state)
       at System.Threading.ExecutionContext.RunInternal(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state, Boolean preserveSyncCtx)
       at System.Threading.ExecutionContext.Run(ExecutionContext executionContext, ContextCallback callback, Object state)
       at System.Threading.ThreadHelper.ThreadStart()
  InnerException: 
       HResult=-2146233088
       Message=Api Error Code: 0 Message: 
       Source=Binance.API.Csharp.Client
       StackTrace:
            at Binance.API.Csharp.Client.ApiClient.<CallAsync>d__1`1.MoveNext()
       InnerException: 

At
var binanceClient =new BinanceClient(apiClient,true);

Hello, i wanna know how to use the ListenDepthEndpoint?

This method returns candle values but decimal values. For example "xrpbtc" daily candle closing value returning "6948" but real value "0.00006948" and "ethbtc" returning "3172" but real value "0.03171153".
Do you have any solution? Should i download code and edit this part for using myself?

Hi There,

Trying to place LIMIT order and getting this exception:

Newtonsoft.Json.JsonReaderException: 'JSON integer 2284305452 is too large or small for an Int32. Path 'orderId', line 1, position 40.'

after running this line:

var buyLimitOrder = await binanceClient.PostNewOrder("BTCUSDT", 0.01m, 8000m, Binance.API.Csharp.Client.Models.Enums.OrderSide.BUY, Binance.API.Csharp.Client.Models.Enums.OrderType.LIMIT);

I am not sure but should the orderId parameter be LONG rather than Int? This error makes trading BTCUSDT pair impossible. Other pairs are ok as order IDs are not so high yet...

The IEnumerable list in the WithdrawHistory.cs has an incorrect type (Deposit). It should be of type Withdraw!

https://github.com/morpheums/Binance.API.Csharp.Client/blob/master/Binance.API.Csharp.Client.Models/Account/WithdrawHistory.cs

AggregateTradeMessage is returning BuyerIsMaker aways true. Anyone with this problem?
I'm trying to make a sort of tape reading analysis...

The API working fantastic, but there are a few optional calls that I would like to utilize from the factory GetKline API call. The factory API call for GetKline allows you to specify the start and end time of a request, which would be a great feature to be added into the code as an optional parameter.

Thanks!

I'm doing tests.

Everything works correctly, except NewOrder method

It returns "Bad Request" (400)

Has this happened to you? Does anybody know what is it due to?

I am new member. When I download sourcecode and open project, but error happen. I using VS profesional 2017.

The switch statement doesn't work because eventData.e isn't being cast to a string.

I ran through the code in debug mode and was able to confirm changing this:
switch (eventData.e)
to this:
switch ((string)eventData.e)
made the switch statement properly evaluate and the event handlers will now fire.

when I try to post new order on market sometimes I've got MIN_NOTIONAL error.
according to my researches, it's because of the Binance trading rules, but I didn't find a way to handle it.

my website is a cryptocurrency shop and when a customer buys for example Bitcoin, I post new BUY BTCUSDT order (Market)

var taskResult = Task.Run(() => binanceClient.PostNewOrder("BTCUSDT", quantity, 0m, OrderSide.BUY, OrderType.MARKET));

Without symbol parameter GetCurrentOpenOrders function should return all open orders for all symbols.

https://github.com/binance-exchange/binance-official-api-docs/blob/master/rest-api.md

I have integrated the Binance.API.Csharp.Client and can get the following listener to work

binanceClient.ListenTradeEndpoint("ethbtc", AggregateTradesHandler3)

So it works in principle.

However, when I try to implement user data it does not initialize:

binanceClient.ListenUserDataEndpoint(AccountHandler, TradesHandler, OrdersHandler);
(I copied the code + the three callback functions from the documentation.)

It fails silently on this line. I can step through it and can see the line where it loses control.

It gets to the following function

public async Task CallAsync(ApiMethod method, string endpoint, bool isSigned = false, string parameters = null)

and does not make it through this line.

var response = await _httpClient.SendAsync(request).ConfigureAwait(false);

I downloaded the API a few days ago and have not made any changes to the wrapper code.

Any ideas as to how to approach this? Does this part of the api work for others?

Thanks

I get the following error when running most modules, where can I change the recvWindow property to get this working?

Exception: Api Error Code: -1021 Message: Timestamp for this request was 1000ms ahead of the server's time.

When I create an order and then retrieve the details using 'GetOrder', I can get all the details from the order but the buy price always shows as 0.00000000, the order has FILLED so it is not that it is waiting to place or anything as it is a market buy. I'd really appreciate any help with this as it's driving me mad...

Thank you for writing this client! I am able to connect when I use the console; however, when I use a Win Forms or WPF, it seems to stall and lock the CPU. Any ideas?

I'm getting this exception whenever i call the binanceclient.PostNewOrderTest()

Cannot implicitly convert type 'Newtonsoft.Json.Linq.JObject' to 'Binance.API.Csharp.Client.Models.Account.NewOrder'

Anybody encounter the issue?

I am using the Websockets. After a while of running, I get the below error.

Unable to read data from the transport connection: An established connection was aborted by the software in your host machine.

using the code

var sellOrder = await client.PostNewOrder("trxbtc", 100m, 0.00000500m, OrderSide.SELL,OrderType.LIMIT);
the api is send the error :
"Api Error Code: -1100 Message: Illegal characters found in parameter 'price'; legal range is '^([0-9]{1,20})(\.[0-9]{1,20})?$'."

If i use int number the same code works fine
ex : var sellOrder = await client.PostNewOrder("trxbtc", 100m, 1m, OrderSide.SELL,OrderType.LIMIT);

Hi,

Sorry i might be doing something wrong. But when i pass a single symbol i get the following error.
It works fine if i pass nothing ( as in returns the 24hour price for all symbols)

System.AggregateException
HResult=0x80131500
Message=One or more errors occurred.
Source=mscorlib
StackTrace:
at System.Threading.Tasks.Task.ThrowIfExceptional(Boolean includeTaskCanceledExceptions)
at System.Threading.Tasks.Task1.GetResultCore(Boolean waitCompletionNotification) at System.Threading.Tasks.Task1.get_Result()
at StockMonitor.Apis.BinanceAPI.Get24HourChangeInfo(String symbol)

Inner Exception 1:
JsonSerializationException: Cannot deserialize the current JSON object (e.g. {"name":"value"}) into type 'System.Collections.Generic.IEnumerable`1[Binance.API.Csharp.Client.Models.Market.PriceChangeInfo]' because the type requires a JSON array (e.g. [1,2,3]) to deserialize correctly.
To fix this error either change the JSON to a JSON array (e.g. [1,2,3]) or change the deserialized type so that it is a normal .NET type (e.g. not a primitive type like integer, not a collection type like an array or List) that can be deserialized from a JSON object. JsonObjectAttribute can also be added to the type to force it to deserialize from a JSON object.
Path 'symbol', line 1, position 10.

According to this document (https://github.com/binance-exchange/binance-official-api-docs/blob/master/user-data-stream.md), the web sockets are disconnecting after 24 hours. Is there a way to add some internal check that either throws an exception or reconnects when the stream loses connectivity?

Thanks!

Hi is there a Method for getting all Statistics for every Symbol, like Binance MainPage?

Hi,

I am getting HttpRequestException: Response status code does not indicate success: 401 (Unauthorized)
when using the GetAccountInfo() function, Other functions like GetAllPrices() works. 
what am i doing wrong?