morko / haxball-room-trapper Goto Github PK

Because of the if (!identifier) check EventTrapper will throw an Error if you pass it 0 as argument to the identifier.

Currently non-event properties are set on the proxied room object without further checks or possibility to intercept. Let's say for example, I want to implement the following behavior:

trappedRoom.nonEventProperty = someValue;

would result in

proxiedRoom.identifier.nonEventProperty = someValue;

It would be nice to add something like this to the EventHandler interface, or (as it's not really dealing with events) add a second, optional handler (say, PropertyHandler) for properties. What do you think? I can create a PR if you tell me what kind of solution you have in mind.