morisset / pyssn Goto Github PK

fic_cosmetik = ''
do_cosmetik = False

Lead to the following when editing a line :

File "/home/morisset/anaconda2/lib/python2.7/site-packages/pyssn/qt/pyssn_qt.py", line 1220, in on_doubleClick
self.show_line_info_dialog()
File "/home/morisset/anaconda2/lib/python2.7/site-packages/pyssn/qt/pyssn_qt.py", line 1198, in show_line_info_dialog
fill_line_info_table()
File "/home/morisset/anaconda2/lib/python2.7/site-packages/pyssn/qt/pyssn_qt.py", line 1049, in fill_line_info_table
line = self.sp.read_line(self.sp.fic_cosmetik, int(line_num))
File "/home/morisset/anaconda2/lib/python2.7/site-packages/pyssn/core/spectrum.py", line 1143, in read_line
with open(filename, 'r') as f:

And they should have a special code.

If cosmetik file only contains a single entry, it crashes...

Perhaps ask Dopita for it IC418 deep spectra?

Could be nice to have an option to add diffused stellar light instead of only BB or PL.

The instrumental profile is now accessible via the variable "prof" in the parameters (may be changed to "instr_prof"?) AND by reading a file named via the "fic_instr_prof" variable.
This is confusing. Better do the same than for the continuum: adding some editing popup window that allows to change the 17 parameters, perhaps in the form:

'HWHM Gauss': [one box for the value]
1 (Bl, Br, decreasing, alpha) : [one box for 4 values]
2 (Bl, Br, decreasing, alpha) : [one box for 4 values]
3 (Bl, Br, decreasing, alpha) : [one box for 4 values]
4 (Bl, Br, decreasing, alpha) : [one box for 4 values]

The values would be saved with the save_parameters facility, and no more need for the fic_instr_prof file.

It seems that there is hard coded a value of 20 for profile number 1. But it is 1.0 in the default profile file.

It could be useful to have a variable that could be edited from the pySSN GUI to store some comments. It may even includes a lambda that would appear on the synthesis (red diamond for example) to inform the user that there is a comment related to this wavelength.
Something like:
comments = (
(4363.0, """ This line is not well fitted because of ....."""),
(7600, """ We have problems here with the atmospheric absorption""")
)

In the init file, change the user-defined continuum from :
cont_intens = (1.0, 2.0, 1.0)
cont_lambda = (4000, 5000, 6000)
into:
cont_lambda_intens = ((4000, 1.0), (5000, 2.0), (6000, 1.0))

It seems that at some stage an extra file was used to put the atmospheric lines, with a different value for the velocity.
Check if this is still actual, and if yes, see how to generate this file from the pySSN_write files facility.

Modify the pySSN_model:
The liste_model file should contain different profile numbers for each line, based on IPs.
These numbers may not correspond to an entry in the profile file, in this case profile number 1 is used.
Difference may apply between Rec and Coll lines.

We need to provide the user with default files for starting a synthesis.
The files are:

• some init file (an example is given on the manual page, do we want a file to be generated automatically)
• list_phyat (already done)
• list_model (already done)
• list_kosmetic (is it generated when the user change a value that needs to be stored as kosmetic?)
• the line profile file. It must be filled with the '1' profile.
• the instrument profile (but see issue where we suggest removing this file to only have the instrumental profile defined in the init file)

It seems that the correction is not the same depending on where the ions are comming from.
Check generate...

File "/Users/christophemorisset/anaconda/envs/py3k5qt4/lib/python3.5/site-packages/pyssn/qt/pyssn_qt.py", line 681, in create_menu
s = s + ' ' + str(i) + ' - ' + items[i] + '\n'
TypeError: 'odict_values' object does not support indexing

That may help to better identify the lines.

There is no easy waynto define a velocity for all the atmospheric lines.
Perhaps use the ID code to identify them and apply a V_ Earth?

We have to think of a way to NOT loose the previous information stored in log and help.dat files.
Perhaps just add at the end of log.dat the new information without removing the one already there.

The continuum should also be convolved by the instrumental profile.
Perhaps also convolve with the Hbeta line profile.

Include a list of depletion factors.

It seems that the temperature is not used to compute the line profile. If V is very small, the profile is close to Dirac, not to thermal width.

being qt_style machine dependent, it should not been saved, as it will avoid transmission from one user to another one.

add 2017 Storey data for the OII rec in Fortran code in place of 2014 data.

Select a wavelength range that includes 4959 and 5007.
In the popup window of the nearby lines, click on the [OIII]5007 line ID (8033400004003): it opens the OIII line info dialog. That's OK.
But click on the [OIII]4959 line ID (8033400004002), it opens the ArIII line info dialog!