Fix bugs identified by ShellCheck about swupdate-openbsd HOT 6 CLOSED

For the SC2260 error ("This redirection overrides the output pipe. Use 'tee' to output to both.") on line 154, the execution of find should have only been redirecting STDERR to /dev/null.

from swupdate-openbsd.

I have fixed the aforementioned SC2260 error (now properly only redirects STDERR, plus the SC2294 warning ("Double quote to prevent globbing and word splitting.") on line 154.

from swupdate-openbsd.

I double-quoted a few command parameters to mitigate possible whitespace/globbing issues (SC2086 errors).

There are still a few remaining errors/warnings/infos identified, but I think they're all very intentional situations.

from swupdate-openbsd.

It looks like one can make ShellCheck ignore certain errors. In our case, I think ignoring one specific instance in a file is what we want for the aforementioned "intentional situations".

from swupdate-openbsd.

I fixed a few more warnings and disabled the ShellCheck warnings regarding how we're abusing eval and arrays in unpriv_ftp(). The only remaining warnings are related to the use of getopt, which would probably be best resolved by using the getopts built-in instead.

from swupdate-openbsd.

I migrated options parsing implementation from getopt to the built-in getopts, which thankfully resolved the remaining ShellCheck complaints. So, this is done.

from swupdate-openbsd.