Git Product home page Git Product logo

interior's People

Contributors

dependabot[bot] avatar johnruane avatar morganfeeney avatar rakr avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

interior's Issues

Baseline grid lines look wrong

Due to the font-size being increased using percentages the distance between the lines created using a gradient sometimes displays incorrectly.

For example on large screens I'm seeing the small screen baseline grid, when I resize the browser window the correct spacing is applied.

Sort out the copious amount of files

I've been experimenting, and making a mess! Time to work out what the actual base theme is, what is included with Interior for it to work without a theme (if relevant), and generally a good tidy up of any excess.

Layout examples needed

This is a list of example layouts I want to create but don't have time for right now.

  • Gallery
  • Column count layout - refer to deleted file, styles will still be available.

Code readability & consistency

Improve the consistency of code and make it more readable by doing the following:

  • Use @media blocks to wrap columns in media queries, as opposed to the $breakpoint mixin argument. This will make the code easier to understand as it is already familiar.
  • Expand all mixin arguments onto separate lines so they reads more like CSS.

Add grids to all pages

Each page should utilise a grid, therefore add the appropriate grid to each section of the site to demonstrate the use of the grid โ€” kinda the point of the site.

Layout alternative

image
Try switching the layout so that the bleed runs off the right, and the text is offset from the left.

Create sitemap

No sitemap submitted to Webmaster Tools. Generate, push and reference.

Things I may document

This is essentially a to do list

  • How the default setup has been customised into the interior theme.

Create more variables

To display the font styles accurately in more than a single place, and to save duplication, some new variables should be created e.g.

$fs-canon: bs(3)
$font-size-h1: $fs-canon;

Centering the grid

The grid-overlay mixin has a flag to set the grid to the center. The CSS output was actually invalid and not doing what I thought it did.

left: calc(50% - $max-width/2);

The variable needs to be interpolated if used in calc().

Marginal interference

When I use a %large (p) in a #main-header and the parent has a bottom margin greater than the child, the vertical rhythm is not correct.

See screenshots.
image

image

Image sizes

Some SVG images sizes are huge. God know how when I'm using artboards to isolate each image.

media queries

Due to the nature of rem/em units and typography, AND the measure, it seems more logical to look at using rem units over px for media queries. It could improve the readability of each layout.

I should also use media queries for viewport height due to the use of negative space and heading alignment, such as the heading-whopper() mixin.

Baseline and flex vertical alignment creep

There seems to be some unwanted spacing occurring when stacking multiple .grid containers. This interferes with the baseline. If you inspect and then uncheck the display flex rule you can see the alignment issue goes away.

It's a bit of creep.

Update the documentation

The documentation is out of date for the next release. This needs to be updated, pages like

  • method
  • grid
  • code samples

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.